[PR #55] [MERGED] Fix String-based path #153

New issue

Closed

opened 2026-02-27 15:46:42 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 15:46:42 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/proxmoxer/proxmoxer/pull/55
Author: @jhollowe
Created: 5/13/2021
Status: ✅ Merged
Merged: 5/20/2021
Merged by: @jhollowe

Base: develop ← Head: get-from-string-path

📝 Commits (1)

ea4d572 Fix string path for get,post,etc

📊 Changes

1 file changed (+2 additions, -2 deletions)

View changed files

📝 proxmoxer/core.py (+2 -2)

📄 Description

Fix proxmox.nodes.get() and proxmox.get("nodes") returning different values by making the ProxmoxAPI class a subclass of the full resource class (ProxmoxResource).

Since the ProxmoxResourceBase class is only used by ProxmoxResource, it could be refactored out and its contents put into ProxmoxResource.
@morph027 what do you think about this?

This is somewhat a breaking change as anyone who attempted a workaround to the bug may have breakage. However, any usage following the README will now work.

resolves #49

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/proxmoxer/proxmoxer/pull/55 **Author:** [@jhollowe](https://github.com/jhollowe) **Created:** 5/13/2021 **Status:** ✅ Merged **Merged:** 5/20/2021 **Merged by:** [@jhollowe](https://github.com/jhollowe) **Base:** `develop` ← **Head:** `get-from-string-path` --- ### 📝 Commits (1) - [`ea4d572`](https://github.com/proxmoxer/proxmoxer/commit/ea4d572e6e47ebaca1eb96aa94cb4670080c660b) Fix string path for get,post,etc ### 📊 Changes **1 file changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `proxmoxer/core.py` (+2 -2) </details> ### 📄 Description Fix proxmox.nodes.get() and proxmox.get("nodes") returning different values by making the ProxmoxAPI class a subclass of the full resource class (`ProxmoxResource`). Since the `ProxmoxResourceBase` class is only used by `ProxmoxResource`, it could be refactored out and its contents put into `ProxmoxResource`. @morph027 what do you think about this? This is *somewhat* a breaking change as anyone who attempted a workaround to the bug may have breakage. However, any usage following the README will now work. resolves #49 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-27 15:46:42 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/proxmoxer#153

No description provided.

Rows
Columns