[PR #43] [MERGED] Generalize Services and Limit to Supported Configurations #148

New issue

Closed

opened 2026-02-27 15:46:40 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 15:46:40 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/proxmoxer/proxmoxer/pull/43
Author: @jhollowe
Created: 12/29/2020
Status: ✅ Merged
Merged: 10/7/2021
Merged by: @jhollowe

Base: develop ← Head: service-generalize

📝 Commits (10+)

89f8c09 Add basics need to work with PBS
b3b2381 Start generalizing service sanitization (HTTPS)
9649bfe Untested work centralizing sanitation
6ae28c6 Add last touch-ups to SSH backends
802262a Merge branch 'develop' into service-generalize
67e68ea Fix config_failure not working
d340199 Remove f-strings to maintain python 2 support
71e64a3 Remove previous sanitization functionality
233d580 Start adding tests for new code
ef214fa Add additional test

📊 Changes

8 files changed (+83 additions, -39 deletions)

View changed files

📝 .gitignore (+2 -0)
📝 proxmoxer/backends/base_ssh.py (+4 -12)
📝 proxmoxer/backends/https.py (+15 -13)
📝 proxmoxer/backends/openssh.py (+1 -2)
📝 proxmoxer/backends/ssh_paramiko.py (+2 -3)
📝 proxmoxer/core.py (+18 -4)
📝 tests/https_tests.py (+25 -3)
📝 tests/paramiko_tests.py (+16 -2)

📄 Description

After testing support for PBS and PMG, I realized there needs to be some sanitation of what services, backends, and authentications that are supported.

This PR adds validation of services and what backends/auths are supported for each service. It also automatically changes the default port to be correct for the selected service.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/proxmoxer/proxmoxer/pull/43 **Author:** [@jhollowe](https://github.com/jhollowe) **Created:** 12/29/2020 **Status:** ✅ Merged **Merged:** 10/7/2021 **Merged by:** [@jhollowe](https://github.com/jhollowe) **Base:** `develop` ← **Head:** `service-generalize` --- ### 📝 Commits (10+) - [`89f8c09`](https://github.com/proxmoxer/proxmoxer/commit/89f8c091781f03a9d9ece697017811f452ee3733) Add basics need to work with PBS - [`b3b2381`](https://github.com/proxmoxer/proxmoxer/commit/b3b23811e817ec56c463e2a292be21dbd67b087a) Start generalizing service sanitization (HTTPS) - [`9649bfe`](https://github.com/proxmoxer/proxmoxer/commit/9649bfe23d2d6338650f26a906fa8add4c079f5b) Untested work centralizing sanitation - [`6ae28c6`](https://github.com/proxmoxer/proxmoxer/commit/6ae28c637360bf6b4c8fbff03f4d5476a3ddfb76) Add last touch-ups to SSH backends - [`802262a`](https://github.com/proxmoxer/proxmoxer/commit/802262a6e06fa8a11d92fbffb7d55db03dce6a74) Merge branch 'develop' into service-generalize - [`67e68ea`](https://github.com/proxmoxer/proxmoxer/commit/67e68eaa7ebc6084fc6937eabbb1b53f66f1a873) Fix config_failure not working - [`d340199`](https://github.com/proxmoxer/proxmoxer/commit/d3401997b978e9efce1a8db91dfeccb0db236909) Remove f-strings to maintain python 2 support - [`71e64a3`](https://github.com/proxmoxer/proxmoxer/commit/71e64a3291eed390611afe9ee98fcf8097f7d52f) Remove previous sanitization functionality - [`233d580`](https://github.com/proxmoxer/proxmoxer/commit/233d580d060055bd2ec1d076d4b51a147e74be44) Start adding tests for new code - [`ef214fa`](https://github.com/proxmoxer/proxmoxer/commit/ef214fad68845cbc6d4f04ee46522c82e5a1e682) Add additional test ### 📊 Changes **8 files changed** (+83 additions, -39 deletions) <details> <summary>View changed files</summary> 📝 `.gitignore` (+2 -0) 📝 `proxmoxer/backends/base_ssh.py` (+4 -12) 📝 `proxmoxer/backends/https.py` (+15 -13) 📝 `proxmoxer/backends/openssh.py` (+1 -2) 📝 `proxmoxer/backends/ssh_paramiko.py` (+2 -3) 📝 `proxmoxer/core.py` (+18 -4) 📝 `tests/https_tests.py` (+25 -3) 📝 `tests/paramiko_tests.py` (+16 -2) </details> ### 📄 Description After testing support for PBS and PMG, I realized there needs to be some sanitation of what services, backends, and authentications that are supported. This PR adds validation of services and what backends/auths are supported for each service. It also automatically changes the default port to be correct for the selected service. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-27 15:46:40 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/proxmoxer#148

No description provided.

Rows
Columns