[PR #29] [MERGED] Fix ticket renewal not updating session cookies #144

New issue

Closed

opened 2026-02-27 15:46:40 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 15:46:40 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/proxmoxer/proxmoxer/pull/29
Author: @jhollowe
Created: 6/21/2020
Status: ✅ Merged
Merged: 6/23/2020
Merged by: @jhollowe

Base: develop ← Head: bugfix.renewal

📝 Commits (1)

d936b6f Fix ticket renewal not updating session cookies

📊 Changes

1 file changed (+15 additions, -4 deletions)

View changed files

📝 proxmoxer/backends/https.py (+15 -4)

📄 Description

Changed session to pull cookies from auth if not specified
Changed printing in https backend to use logger

The auth was correctly renewing the ticket, but only the original ticket was in the session and was ever actually sent. Now the session will pull cookies from the auth if no cookies are supplied.

prompted by home-assistant/core#36853

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/proxmoxer/proxmoxer/pull/29 **Author:** [@jhollowe](https://github.com/jhollowe) **Created:** 6/21/2020 **Status:** ✅ Merged **Merged:** 6/23/2020 **Merged by:** [@jhollowe](https://github.com/jhollowe) **Base:** `develop` ← **Head:** `bugfix.renewal` --- ### 📝 Commits (1) - [`d936b6f`](https://github.com/proxmoxer/proxmoxer/commit/d936b6f48b56c40fc45c36370581a69ecfcd491c) Fix ticket renewal not updating session cookies ### 📊 Changes **1 file changed** (+15 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `proxmoxer/backends/https.py` (+15 -4) </details> ### 📄 Description * Changed session to pull cookies from auth if not specified * Changed printing in https backend to use logger The auth was correctly renewing the ticket, but only the original ticket was in the session and was ever actually sent. Now the session will pull cookies from the auth if no cookies are supplied. prompted by home-assistant/core#36853 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-27 15:46:40 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/proxmoxer#144

No description provided.

Rows
Columns