[PR #25] [MERGED] Deprecate old token auth #139

New issue

Closed

opened 2026-02-27 15:46:38 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 15:46:38 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/proxmoxer/proxmoxer/pull/25
Author: @jhollowe
Created: 5/20/2020
Status: ✅ Merged
Merged: 5/21/2020
Merged by: @morph027

Base: develop ← Head: deprecate-old-token-auth

📝 Commits (3)

24c04fa Depricate existing token auth
0c4f3b0 Refactor names to be distinct
95c9268 Fix renaming error

📊 Changes

2 files changed (+26 additions, -20 deletions)

View changed files

📝 proxmoxer/backends/https.py (+25 -19)
📝 tests/https_tests.py (+1 -1)

📄 Description

The ProxmoxHTTPTokenAuth auth is redundant. If the user needs a stateless authentication, the API Token auth can now be used; if the user wants to use the user/password auth, the existing ticket can just be passed as the password and a fresh ticket and CSRF token will be generated.

It will also cause unneeded confusion now with the API Token auth which sounds similar but is completely different.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/proxmoxer/proxmoxer/pull/25 **Author:** [@jhollowe](https://github.com/jhollowe) **Created:** 5/20/2020 **Status:** ✅ Merged **Merged:** 5/21/2020 **Merged by:** [@morph027](https://github.com/morph027) **Base:** `develop` ← **Head:** `deprecate-old-token-auth` --- ### 📝 Commits (3) - [`24c04fa`](https://github.com/proxmoxer/proxmoxer/commit/24c04fa42cd5ab7b9b0d0f788ccb1615176fe54e) Depricate existing token auth - [`0c4f3b0`](https://github.com/proxmoxer/proxmoxer/commit/0c4f3b0b1b68602059960fd8812793b58a16c255) Refactor names to be distinct - [`95c9268`](https://github.com/proxmoxer/proxmoxer/commit/95c9268d7081aaedb0dd61cc538add546106c4ec) Fix renaming error ### 📊 Changes **2 files changed** (+26 additions, -20 deletions) <details> <summary>View changed files</summary> 📝 `proxmoxer/backends/https.py` (+25 -19) 📝 `tests/https_tests.py` (+1 -1) </details> ### 📄 Description The `ProxmoxHTTPTokenAuth` auth is redundant. If the user needs a stateless authentication, the API Token auth can now be used; if the user wants to use the user/password auth, the existing ticket can just be passed as the password and a fresh ticket and CSRF token will be generated. It will also cause unneeded confusion now with the API Token auth which sounds similar but is completely different. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-27 15:46:38 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/proxmoxer#139

No description provided.

Rows
Columns