[PR #24] [MERGED] Fix get_tokens() error with API tokens #138

New issue

Closed

opened 2026-02-27 15:46:38 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 15:46:38 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/proxmoxer/proxmoxer/pull/24
Author: @jhollowe
Created: 5/20/2020
Status: ✅ Merged
Merged: 5/20/2020
Merged by: @jhollowe

Base: develop ← Head: fix-get_tokens

📝 Commits (4)

aecbffd Fix get_tokens() error with API tokens
a8b1fcb Add get_tokens() test for API Token auth
121ee80 Add get_tokens() test for user/password auth
325e877 Remove get_tokens() test for user/password auth

📊 Changes

3 files changed (+8 additions, -6 deletions)

View changed files

📝 proxmoxer/backends/https.py (+4 -4)
📝 proxmoxer/core.py (+1 -1)
📝 tests/https_tests.py (+3 -1)

📄 Description

calling get_tokens() on an API Token auth throws an error. This solves the problem by properly passing the get_token call to the auth rather than the backend and correctly sets a default of (None, None) for the returned tokens.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/proxmoxer/proxmoxer/pull/24 **Author:** [@jhollowe](https://github.com/jhollowe) **Created:** 5/20/2020 **Status:** ✅ Merged **Merged:** 5/20/2020 **Merged by:** [@jhollowe](https://github.com/jhollowe) **Base:** `develop` ← **Head:** `fix-get_tokens` --- ### 📝 Commits (4) - [`aecbffd`](https://github.com/proxmoxer/proxmoxer/commit/aecbffd286c8b1a495f2420d6f45cdc2dc752b3d) Fix get_tokens() error with API tokens - [`a8b1fcb`](https://github.com/proxmoxer/proxmoxer/commit/a8b1fcbdf776a4b9cd78c9032e2b750c770b8a99) Add get_tokens() test for API Token auth - [`121ee80`](https://github.com/proxmoxer/proxmoxer/commit/121ee80b4a8fdaccf22edc158d13b1d3813ee67f) Add get_tokens() test for user/password auth - [`325e877`](https://github.com/proxmoxer/proxmoxer/commit/325e877423d94741482d965d6a6f434720e5c839) Remove get_tokens() test for user/password auth ### 📊 Changes **3 files changed** (+8 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `proxmoxer/backends/https.py` (+4 -4) 📝 `proxmoxer/core.py` (+1 -1) 📝 `tests/https_tests.py` (+3 -1) </details> ### 📄 Description calling `get_tokens()` on an API Token auth throws an error. This solves the problem by properly passing the get_token call to the auth rather than the backend and correctly sets a default of (None, None) for the returned tokens. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-27 15:46:38 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-27 15:46:50 +03:00

[PR #138] [MERGED] Add repr to some classes and add to tests #191

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/proxmoxer#138

No description provided.

Rows
Columns