[PR #6] [MERGED] pveapi: allow disabling TLS certificate verification #11

Closed
opened 2026-03-14 08:23:56 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/andrew-d/proxmox-service-discovery/pull/6
Author: @andrew-d
Created: 4/11/2025
Status: Merged
Merged: 4/11/2025
Merged by: @andrew-d

Base: mainHead: andrew/tls-cert-flag


📝 Commits (1)

  • 5e967bf pveapi: allow disabling TLS certificate verification

📊 Changes

6 files changed (+144 additions, -66 deletions)

View changed files

📝 debug.go (+76 -39)
📝 go.mod (+4 -3)
📝 go.sum (+8 -6)
📝 internal/pveapi/api.go (+8 -6)
📝 internal/pveapi/auth.go (+8 -5)
📝 main.go (+40 -7)

📄 Description

This allows connecting to a Proxmox server that either doesn't have a certificate issued from a public CA, or one where the FQDN of the server doesn't match the name on the certificate.

Updates #4


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/andrew-d/proxmox-service-discovery/pull/6 **Author:** [@andrew-d](https://github.com/andrew-d) **Created:** 4/11/2025 **Status:** ✅ Merged **Merged:** 4/11/2025 **Merged by:** [@andrew-d](https://github.com/andrew-d) **Base:** `main` ← **Head:** `andrew/tls-cert-flag` --- ### 📝 Commits (1) - [`5e967bf`](https://github.com/andrew-d/proxmox-service-discovery/commit/5e967bf62be14e8fd9fda814ce90d0449b30069a) pveapi: allow disabling TLS certificate verification ### 📊 Changes **6 files changed** (+144 additions, -66 deletions) <details> <summary>View changed files</summary> 📝 `debug.go` (+76 -39) 📝 `go.mod` (+4 -3) 📝 `go.sum` (+8 -6) 📝 `internal/pveapi/api.go` (+8 -6) 📝 `internal/pveapi/auth.go` (+8 -5) 📝 `main.go` (+40 -7) </details> ### 📄 Description This allows connecting to a Proxmox server that either doesn't have a certificate issued from a public CA, or one where the FQDN of the server doesn't match the name on the certificate. Updates #4 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-14 08:23:56 +03:00
Sign in to join this conversation.
No labels
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/proxmox-service-discovery#11
No description provided.