starred/proxmox-api-go
1
0
Fork 0
mirror of https://github.com/Telmate/proxmox-api-go.git synced 2026-04-26 07:55:50 +03:00
Code Issues 62 Projects Releases Packages Wiki Activity

[GH-ISSUE #379] Refactor: make everything in session.go private #95

New issue
Closed
opened 2026-02-28 00:40:33 +03:00 by kerem · 3 comments
kerem commented 2026-02-28 00:40:33 +03:00
Owner
Copy link

Originally created by @Tinyblargon on GitHub (Nov 24, 2024).
Original GitHub issue: https://github.com/Telmate/proxmox-api-go/issues/379

Originally assigned to: @angyaljanos on GitHub.

The file session.go exposes a few types and functions that are not fur use outside of this project.
These parts should be made private.

Originally created by @Tinyblargon on GitHub (Nov 24, 2024). Original GitHub issue: https://github.com/Telmate/proxmox-api-go/issues/379 Originally assigned to: @angyaljanos on GitHub. The file `session.go` exposes a few types and functions that are not fur use outside of this project. These parts should be made private.
kerem 2026-02-28 00:40:33 +03:00
kerem commented 2026-02-28 00:40:33 +03:00
Author
Owner
Copy link

@angyaljanos commented on GitHub (Jun 17, 2025):

Hi @Tinyblargon!
Is this issue is still open? I am egaer to help but very new to contribute to opensource.

<!-- gh-comment-id:2979408746 --> @angyaljanos commented on GitHub (Jun 17, 2025): Hi @Tinyblargon! Is this issue is still open? I am egaer to help but very new to contribute to opensource.
kerem commented 2026-02-28 00:40:33 +03:00
Author
Owner
Copy link

@Tinyblargon commented on GitHub (Jun 17, 2025):

@angyaljanos thank you for having an interest in contributing. This issue is still open and should be some refactoring.

Do you have any prior experience with Go?

If you want to start working on this I'll assing the issue to you. You can fork the project and make a Pull Request incorperating your changes.
If you need any further help feel free to ask.

Most of the time contributions to this project are as follows:

  1. contributor creates issue for the enhancement/change they would want in the project.
  2. we discuss the how and why of the change.
  3. contributor inplements the discuss enhancement/change in their fork.
  4. contributor creates Pull Request.
  5. Pull Request gets reviewed.
  6. Minor changes are made to enhancement/change.
  7. Pull Request gets merged.
<!-- gh-comment-id:2981037387 --> @Tinyblargon commented on GitHub (Jun 17, 2025): @angyaljanos thank you for having an interest in contributing. This issue is still open and should be some refactoring. Do you have any prior experience with Go? If you want to start working on this I'll assing the issue to you. You can fork the project and make a Pull Request incorperating your changes. If you need any further help feel free to ask. Most of the time contributions to this project are as follows: 1. contributor creates issue for the enhancement/change they would want in the project. 2. we discuss the how and why of the change. 3. contributor inplements the discuss enhancement/change in their fork. 4. contributor creates Pull Request. 5. Pull Request gets reviewed. 6. Minor changes are made to enhancement/change. 7. Pull Request gets merged.
kerem commented 2026-02-28 00:40:33 +03:00
Author
Owner
Copy link

@Tinyblargon commented on GitHub (Jun 23, 2025):

Closed by #432

<!-- gh-comment-id:2997170668 --> @Tinyblargon commented on GitHub (Jun 23, 2025): Closed by #432
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
dependabot/go_modules/golang.org/x/crypto-0.45.0
issue-300-fix
go-119-upgrade
logic-improvements
getUserPermissions
cicustom
next_if_conflict
cloud-init
add_full_clone_option
No results found.
Labels
Clear labels   
good first issue

   
issue/confirmed

   
issue/critical

   
proposal/accepted

   
pull-request

Mirrored from GitHub Pull Request

  
type/bug

   
type/enhancement

   
type/feature

   
type/question

   
type/refactoring

   
type/testing

   
type/testing
No labels
good first issue
issue/confirmed
issue/critical
proposal/accepted
pull-request
type/bug
type/enhancement
type/feature
type/question
type/refactoring
type/testing
type/testing
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/proxmox-api-go#95
No description provided.