starred/proxmox-api-go
1
0
Fork 0
mirror of https://github.com/Telmate/proxmox-api-go.git synced 2026-04-25 15:35:51 +03:00
Code Issues 62 Projects Releases Packages Wiki Activity

[GH-ISSUE #341] Overhaul: Qemu Network interfaces. #82

New issue
Closed
opened 2026-02-28 00:40:30 +03:00 by kerem · 2 comments
kerem commented 2026-02-28 00:40:30 +03:00
Owner
Copy link

Originally created by @Tinyblargon on GitHub (Jun 13, 2024).
Original GitHub issue: https://github.com/Telmate/proxmox-api-go/issues/341

Originally assigned to: @Tinyblargon on GitHub.

The network adapters of ConfigQemu{} don't neatly map to the data-structure the PVE API uses.
We currently use an array.
PVE uses an map[id]settings.

With our current implementation it's not possible to have network interfaces that aren't consecutive.
In PVE users can have interface1 and interface3 configured. Our current implantation can't distinguish between.

  • inteface1
  • interface2

and

  • interface1
  • interface5

In this instance interface5 is the second interface. so it will be the second item in the array.
Before you start working on this please discuss it with me.

Originally created by @Tinyblargon on GitHub (Jun 13, 2024). Original GitHub issue: https://github.com/Telmate/proxmox-api-go/issues/341 Originally assigned to: @Tinyblargon on GitHub. The network adapters of `ConfigQemu{}` don't neatly map to the data-structure the PVE API uses. We currently use an array. PVE uses an map[id]settings. With our current implementation it's not possible to have network interfaces that aren't consecutive. In PVE users can have interface1 and interface3 configured. Our current implantation can't distinguish between. - inteface1 - interface2 and - interface1 - interface5 In this instance interface5 is the second interface. so it will be the second item in the array. Before you start working on this please discuss it with me.
kerem 2026-02-28 00:40:30 +03:00
kerem commented 2026-02-28 00:40:30 +03:00
Author
Owner
Copy link

@Tinyblargon commented on GitHub (Jun 21, 2024):

This will include #333

<!-- gh-comment-id:2182493767 --> @Tinyblargon commented on GitHub (Jun 21, 2024): This will include #333
kerem commented 2026-02-28 00:40:30 +03:00
Author
Owner
Copy link

@Tinyblargon commented on GitHub (Aug 27, 2024):

Working on this in https://github.com/Tinyblargon/proxmox-api-go/tree/%23341

<!-- gh-comment-id:2313042691 --> @Tinyblargon commented on GitHub (Aug 27, 2024): Working on this in https://github.com/Tinyblargon/proxmox-api-go/tree/%23341
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
dependabot/go_modules/golang.org/x/crypto-0.45.0
issue-300-fix
go-119-upgrade
logic-improvements
getUserPermissions
cicustom
next_if_conflict
cloud-init
add_full_clone_option
No results found.
Labels
Clear labels   
good first issue

   
issue/confirmed

   
issue/critical

   
proposal/accepted

   
pull-request

Mirrored from GitHub Pull Request

  
type/bug

   
type/enhancement

   
type/feature

   
type/question

   
type/refactoring

   
type/testing

   
type/testing
No labels
good first issue
issue/confirmed
issue/critical
proposal/accepted
pull-request
type/bug
type/enhancement
type/feature
type/question
type/refactoring
type/testing
type/testing
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/proxmox-api-go#82
No description provided.