mirror of
https://github.com/Telmate/proxmox-api-go.git
synced 2026-04-25 15:35:51 +03:00
[GH-ISSUE #302] Refactor: mapping disks to API #64
Labels
No labels
good first issue
issue/confirmed
issue/critical
proposal/accepted
pull-request
type/bug
type/enhancement
type/feature
type/question
type/refactoring
type/testing
type/testing
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/proxmox-api-go#64
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @Tinyblargon on GitHub (Jan 22, 2024).
Original GitHub issue: https://github.com/Telmate/proxmox-api-go/issues/302
Originally assigned to: @Tinyblargon on GitHub.
While working on #299 I realized the following code could easily be restructured to make it more readable.
github.com/Telmate/proxmox-api-go@e1cc849068/proxmox/config_qemu_disk.go (L1005-L1019)This restructure would get rid of the following code:
github.com/Telmate/proxmox-api-go@e1cc849068/proxmox/config_qemu_disk_ide.go (L60-L79)github.com/Telmate/proxmox-api-go@e1cc849068/proxmox/config_qemu_disk_sata.go (L62-L83)github.com/Telmate/proxmox-api-go@e1cc849068/proxmox/config_qemu_disk_scsi.go (L91-L137)github.com/Telmate/proxmox-api-go@e1cc849068/proxmox/config_qemu_disk_virtio.go (L74-L105)