[PR #521] [MERGED] feat: return agent state as enum #522

New issue

Closed

opened 2026-02-28 00:42:31 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 00:42:31 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Telmate/proxmox-api-go/pull/521
Author: @Tinyblargon
Created: 11/17/2025
Status: ✅ Merged
Merged: 11/23/2025
Merged by: @Tinyblargon

Base: master ← Head: QemuAgent-ok

📝 Commits (4)

c786c62 feat: return agent state as enum
90fd4c6 fix: wrong parameter name
4868fa2 fix: logic issue
d8bba3f refactor: rename state enum

📊 Changes

6 files changed (+37 additions, -20 deletions)

View changed files

📝 proxmox/client.go (+7 -1)
📝 proxmox/client__api.go (+4 -3)
📝 proxmox/client__api__mock.go (+3 -3)
📝 proxmox/client__new.go (+1 -1)
📝 proxmox/client__new__mock.go (+2 -2)
📝 proxmox/data__qemu__agent.go (+20 -10)

📄 Description

Before we returned the agent state as errors downstream projects would have to parse.
Now we return an enum, removing the need for downstream error parsing for agent related errors.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Telmate/proxmox-api-go/pull/521 **Author:** [@Tinyblargon](https://github.com/Tinyblargon) **Created:** 11/17/2025 **Status:** ✅ Merged **Merged:** 11/23/2025 **Merged by:** [@Tinyblargon](https://github.com/Tinyblargon) **Base:** `master` ← **Head:** `QemuAgent-ok` --- ### 📝 Commits (4) - [`c786c62`](https://github.com/Telmate/proxmox-api-go/commit/c786c6264470d71c33ef815bed62d9037c1cf159) feat: return agent state as enum - [`90fd4c6`](https://github.com/Telmate/proxmox-api-go/commit/90fd4c69e1b8dba6c3e2b949df25808ec6dd9347) fix: wrong parameter name - [`4868fa2`](https://github.com/Telmate/proxmox-api-go/commit/4868fa28a48be698f6e4f1f4ae7f41b0bbca5d7c) fix: logic issue - [`d8bba3f`](https://github.com/Telmate/proxmox-api-go/commit/d8bba3fbd6fc68e2345d959f431c61071a7e3433) refactor: rename state enum ### 📊 Changes **6 files changed** (+37 additions, -20 deletions) <details> <summary>View changed files</summary> 📝 `proxmox/client.go` (+7 -1) 📝 `proxmox/client__api.go` (+4 -3) 📝 `proxmox/client__api__mock.go` (+3 -3) 📝 `proxmox/client__new.go` (+1 -1) 📝 `proxmox/client__new__mock.go` (+2 -2) 📝 `proxmox/data__qemu__agent.go` (+20 -10) </details> ### 📄 Description Before we returned the agent state as errors downstream projects would have to parse. Now we return an enum, removing the need for downstream error parsing for agent related errors. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>