[PR #505] [MERGED] migrate: add delete and set acmeplugin to the new cli #511

New issue

Closed

opened 2026-02-28 00:42:28 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 00:42:28 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Telmate/proxmox-api-go/pull/505
Author: @NemoDacremont
Created: 10/30/2025
Status: ✅ Merged
Merged: 10/30/2025
Merged by: @Tinyblargon

Base: master ← Head: migrate/cli-del-set-acme-plugin

📝 Commits (2)

a9e61df migrate: add set acmeplugin to the new cli
2a28997 migrate: add delete acmeplugin to the new cli

📊 Changes

3 files changed (+53 additions, -0 deletions)

View changed files

➕ cli/command/delete/delete-acmeplugin.go (+19 -0)
📝 cli/command/delete/delete.go (+2 -0)
➕ cli/command/set/set-acmeplugin.go (+32 -0)

📄 Description

I merged the two addition in one PR to prevent creating too many of them

Add delete acmeplugin to the CLI
Add set acmeplugin to the CLI

closes #503
closes #504

Test

cat << EOF > acme.json
{
  "api": "aws",
  "data": "AWS_ACCESS_KEY_ID=DEMOACCESSKEYID\nAWS_SECRET_ACCESS_KEY=DEMOSECRETACCESSKEY\n",
  "enable": true,
  "validation-delay": 30
}
EOF
NEW_CLI=true proxmox-api-go -i set acmeplugin --file acme.json test
NEW_CLI=true proxmox-api-go -i list acmeplugins
# {"data":[{"api":"aws","data":"AWS_ACCESS_KEY_ID=DEMOACCESSKEYID\nAWS_SECRET_ACCESS_KEY=DEMOSECRETACCESSKEY\n","digest":"b17f493f7034f964f1f5d98208db5548011f2020","plugin":"test","type":"dns","validation-delay":30},{"digest":"b17f493f7034f964f1f5d98208db5548011f2020","plugin":"standalone","type":"standalone"}]}
NEW_CLI=true proxmox-api-go -i delete acmeplugin test
NEW_CLI=true proxmox-api-go -i list acmeplugins
# {"data":[{"digest":"ddffdc6c1d97004ae1dddda32a03ad2779f83373","plugin":"standalone","type":"standalone"}]}
rm acme.json

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Telmate/proxmox-api-go/pull/505 **Author:** [@NemoDacremont](https://github.com/NemoDacremont) **Created:** 10/30/2025 **Status:** ✅ Merged **Merged:** 10/30/2025 **Merged by:** [@Tinyblargon](https://github.com/Tinyblargon) **Base:** `master` ← **Head:** `migrate/cli-del-set-acme-plugin` --- ### 📝 Commits (2) - [`a9e61df`](https://github.com/Telmate/proxmox-api-go/commit/a9e61dfa6c51629121096c2b8be5b1ca2303beca) migrate: add set acmeplugin to the new cli - [`2a28997`](https://github.com/Telmate/proxmox-api-go/commit/2a28997bdf21eecec88bf97dc1a92fac6ccc61c6) migrate: add delete acmeplugin to the new cli ### 📊 Changes **3 files changed** (+53 additions, -0 deletions) <details> <summary>View changed files</summary> ➕ `cli/command/delete/delete-acmeplugin.go` (+19 -0) 📝 `cli/command/delete/delete.go` (+2 -0) ➕ `cli/command/set/set-acmeplugin.go` (+32 -0) </details> ### 📄 Description I merged the two addition in one PR to prevent creating too many of them * Add `delete acmeplugin` to the CLI * Add `set acmeplugin` to the CLI closes #503 closes #504 ### Test ```sh cat << EOF > acme.json { "api": "aws", "data": "AWS_ACCESS_KEY_ID=DEMOACCESSKEYID\nAWS_SECRET_ACCESS_KEY=DEMOSECRETACCESSKEY\n", "enable": true, "validation-delay": 30 } EOF NEW_CLI=true proxmox-api-go -i set acmeplugin --file acme.json test NEW_CLI=true proxmox-api-go -i list acmeplugins # {"data":[{"api":"aws","data":"AWS_ACCESS_KEY_ID=DEMOACCESSKEYID\nAWS_SECRET_ACCESS_KEY=DEMOSECRETACCESSKEY\n","digest":"b17f493f7034f964f1f5d98208db5548011f2020","plugin":"test","type":"dns","validation-delay":30},{"digest":"b17f493f7034f964f1f5d98208db5548011f2020","plugin":"standalone","type":"standalone"}]} NEW_CLI=true proxmox-api-go -i delete acmeplugin test NEW_CLI=true proxmox-api-go -i list acmeplugins # {"data":[{"digest":"ddffdc6c1d97004ae1dddda32a03ad2779f83373","plugin":"standalone","type":"standalone"}]} rm acme.json ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>