[PR #478] fix: keep attributes when required on configSDNZone.mapToApiValues #498

New issue

Open

opened 2026-02-28 00:42:25 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 00:42:25 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Telmate/proxmox-api-go/pull/478
Author: @NemoDacremont
Created: 10/9/2025
Status: 🔄 Open

Base: master ← Head: fix/sdn-maptoapi-broken

📝 Commits (4)

3874712 fix: keep attributes when required on configSDNZone.mapToApiValues
823deb4 feat: breaking use GetItemConfigMap to return object directly and not data: {} ; and add NewConfigSDNZoneFromApi
d660623 test: add create, update and delete tests for sdn zones
b4e5489 clean: remove log.println and use consts in sdn zone tests

📊 Changes

3 files changed (+104 additions, -8 deletions)

View changed files

📝 proxmox/client.go (+1 -1)
📝 proxmox/config__sdn__zone.go (+25 -7)
➕ test/api/Sdn/sdn_zone_create_update_delete_test.go (+78 -0)

📄 Description

Sorry for the amount of patches I'm submitting, this one is smaller and straight forward.

It fixes #467, it uses the same create flag as in Validate to know if it should drop the type attribute.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Telmate/proxmox-api-go/pull/478 **Author:** [@NemoDacremont](https://github.com/NemoDacremont) **Created:** 10/9/2025 **Status:** 🔄 Open **Base:** `master` ← **Head:** `fix/sdn-maptoapi-broken` --- ### 📝 Commits (4) - [`3874712`](https://github.com/Telmate/proxmox-api-go/commit/3874712c782677d8be27ce7e6656d979617a1a74) fix: keep attributes when required on configSDNZone.mapToApiValues - [`823deb4`](https://github.com/Telmate/proxmox-api-go/commit/823deb4de9fd0e71420770b7b93dee4dc470ffc4) feat: breaking use GetItemConfigMap to return object directly and not data: {} ; and add NewConfigSDNZoneFromApi - [`d660623`](https://github.com/Telmate/proxmox-api-go/commit/d66062311755e977ce5b0f3e55316e07bf5b5543) test: add create, update and delete tests for sdn zones - [`b4e5489`](https://github.com/Telmate/proxmox-api-go/commit/b4e548973d658872a53df8f2718890318305d6d4) clean: remove log.println and use consts in sdn zone tests ### 📊 Changes **3 files changed** (+104 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `proxmox/client.go` (+1 -1) 📝 `proxmox/config__sdn__zone.go` (+25 -7) ➕ `test/api/Sdn/sdn_zone_create_update_delete_test.go` (+78 -0) </details> ### 📄 Description Sorry for the amount of patches I'm submitting, this one is smaller and straight forward. It fixes #467, it uses the same `create` flag as in `Validate` to know if it should drop the `type` attribute. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>