[PR #456] [MERGED] refactor: `GuestType` #485

New issue

Closed

opened 2026-02-28 00:42:22 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 00:42:22 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Telmate/proxmox-api-go/pull/456
Author: @Tinyblargon
Created: 9/9/2025
Status: ✅ Merged
Merged: 9/9/2025
Merged by: @Tinyblargon

Base: master ← Head: guest-type

📝 Commits (3)

ae4a5f3 refactor: GuestType
302ffcd fix: vmRef misused for passing node
aae9ef6 docs: explain GuestType

📊 Changes

17 files changed (+166 additions, -54 deletions)

View changed files

📝 cli/command/get/guest/get-guest-config.go (+2 -2)
📝 main.go (+2 -2)
📝 proxmox/client.go (+14 -18)
📝 proxmox/client__api.go (+1 -1)
📝 proxmox/config__guest.go (+41 -6)
📝 proxmox/config__guest__resource.go (+7 -2)
📝 proxmox/config__guest__resource_test.go (+1 -1)
📝 proxmox/config__guest_test.go (+76 -0)
📝 proxmox/config__lxc.go (+2 -2)
📝 proxmox/config__lxc__new.go (+1 -1)
📝 proxmox/config__qemu.go (+4 -4)
📝 proxmox/snapshot.go (+5 -5)
📝 proxmox/vmref.go (+6 -6)
📝 test/api/CloudInit/shared_test.go (+1 -1)
📝 test/api/Lxc/shared_test.go (+1 -1)
📝 test/api/Qemu/qemu_clone_test.go (+1 -1)
📝 test/api/Qemu/shared_test.go (+1 -1)

📄 Description

Use an enum instead of a string for GuestType.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Telmate/proxmox-api-go/pull/456 **Author:** [@Tinyblargon](https://github.com/Tinyblargon) **Created:** 9/9/2025 **Status:** ✅ Merged **Merged:** 9/9/2025 **Merged by:** [@Tinyblargon](https://github.com/Tinyblargon) **Base:** `master` ← **Head:** `guest-type` --- ### 📝 Commits (3) - [`ae4a5f3`](https://github.com/Telmate/proxmox-api-go/commit/ae4a5f37002fee568ecc85f06cfbdc37010970c7) refactor: `GuestType` - [`302ffcd`](https://github.com/Telmate/proxmox-api-go/commit/302ffcd1a85cdddea1785d6b578a4b1db830d413) fix: vmRef misused for passing node - [`aae9ef6`](https://github.com/Telmate/proxmox-api-go/commit/aae9ef6401be584b82ac4c28c4252939a68f5968) docs: explain `GuestType` ### 📊 Changes **17 files changed** (+166 additions, -54 deletions) <details> <summary>View changed files</summary> 📝 `cli/command/get/guest/get-guest-config.go` (+2 -2) 📝 `main.go` (+2 -2) 📝 `proxmox/client.go` (+14 -18) 📝 `proxmox/client__api.go` (+1 -1) 📝 `proxmox/config__guest.go` (+41 -6) 📝 `proxmox/config__guest__resource.go` (+7 -2) 📝 `proxmox/config__guest__resource_test.go` (+1 -1) 📝 `proxmox/config__guest_test.go` (+76 -0) 📝 `proxmox/config__lxc.go` (+2 -2) 📝 `proxmox/config__lxc__new.go` (+1 -1) 📝 `proxmox/config__qemu.go` (+4 -4) 📝 `proxmox/snapshot.go` (+5 -5) 📝 `proxmox/vmref.go` (+6 -6) 📝 `test/api/CloudInit/shared_test.go` (+1 -1) 📝 `test/api/Lxc/shared_test.go` (+1 -1) 📝 `test/api/Qemu/qemu_clone_test.go` (+1 -1) 📝 `test/api/Qemu/shared_test.go` (+1 -1) </details> ### 📄 Description Use an enum instead of a string for `GuestType`. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>