[PR #433] [MERGED] Lxc mounts prerequisites #466

New issue

Closed

opened 2026-02-28 00:42:18 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 00:42:18 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Telmate/proxmox-api-go/pull/433
Author: @Tinyblargon
Created: 7/1/2025
Status: ✅ Merged
Merged: 7/2/2025
Merged by: @Tinyblargon

Base: master ← Head: lxc-mounts

📝 Commits (10+)

5f50b4f refactor: reduce map lookups
ff8d2c2 perf: recduce number of allocs
e2feff9 test: RawConfigLXC.Privileged()
9e5e861 refactor: remove pointer from RawConfigLXC.Name
a3386ee refactor: remove pointer from RawConfigLXC.Swap
aaefb6b refactor: remove pointer from RawConfigLXC.Memory
21a8a08 feat: PowerState
9da595e feat: LXC root resizing & moving
8323ad0 refactor: digest & bootmount
9121991 feat: add moving logic

📊 Changes

18 files changed (+820 additions, -158 deletions)

View changed files

📝 cli/command/guest/guest-status.go (+2 -2)
📝 cli/command/guest/guest-uptime.go (+3 -2)
📝 proxmox/client.go (+1 -0)
📝 proxmox/config_guest.go (+21 -21)
📝 proxmox/config_guest_test.go (+4 -4)
📝 proxmox/config_lxc__features.go (+5 -1)
➕ proxmox/config_lxc__features_test.go (+21 -0)
📝 proxmox/config_lxc__mount.go (+84 -23)
📝 proxmox/config_lxc__mount_test.go (+82 -0)
📝 proxmox/config_lxc_new.go (+171 -48)
📝 proxmox/config_lxc_new_test.go (+190 -43)
📝 proxmox/config_qemu.go (+8 -8)
➕ proxmox/type_powerstate.go (+40 -0)
➕ proxmox/type_powerstate_test.go (+77 -0)
📝 proxmox/util.go (+15 -6)
📝 proxmox/util_test.go (+8 -0)
📝 proxmox/vmref.go (+52 -0)
📝 proxmox/vmref_test.go (+36 -0)

📄 Description

While attempting to implement LXC mount I came across a lot of prerequisites that had to be implemented first.
Instead of bloating that pr with all these prerequisites I'm merging it now.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Telmate/proxmox-api-go/pull/433 **Author:** [@Tinyblargon](https://github.com/Tinyblargon) **Created:** 7/1/2025 **Status:** ✅ Merged **Merged:** 7/2/2025 **Merged by:** [@Tinyblargon](https://github.com/Tinyblargon) **Base:** `master` ← **Head:** `lxc-mounts` --- ### 📝 Commits (10+) - [`5f50b4f`](https://github.com/Telmate/proxmox-api-go/commit/5f50b4f47fb8a778199ce08116c47f3d077429d0) refactor: reduce map lookups - [`ff8d2c2`](https://github.com/Telmate/proxmox-api-go/commit/ff8d2c28e20f7d8e1212a03ccfb163be1575a6da) perf: recduce number of allocs - [`e2feff9`](https://github.com/Telmate/proxmox-api-go/commit/e2feff9c305c339a455d26412ec2d13f43f98075) test: RawConfigLXC.Privileged() - [`9e5e861`](https://github.com/Telmate/proxmox-api-go/commit/9e5e8614a32427b621ee6b0e3053858a5816c16b) refactor: remove pointer from RawConfigLXC.Name - [`a3386ee`](https://github.com/Telmate/proxmox-api-go/commit/a3386eee86ba601a7ce5ff9a59cbd0b2a67b4dec) refactor: remove pointer from RawConfigLXC.Swap - [`aaefb6b`](https://github.com/Telmate/proxmox-api-go/commit/aaefb6b15ce90dd12cd04915cd80427905d2b55c) refactor: remove pointer from RawConfigLXC.Memory - [`21a8a08`](https://github.com/Telmate/proxmox-api-go/commit/21a8a08f5d3635c23a4c9cf5c534b5ea5ac7f8ec) feat: PowerState - [`9da595e`](https://github.com/Telmate/proxmox-api-go/commit/9da595ec6e53c68425124213539a4f1cad7db617) feat: LXC root resizing & moving - [`8323ad0`](https://github.com/Telmate/proxmox-api-go/commit/8323ad07f583575a299ec4766a7cfe95b219deb6) refactor: digest & bootmount - [`9121991`](https://github.com/Telmate/proxmox-api-go/commit/9121991fb62dff91a764526453d22ebdb04871df) feat: add moving logic ### 📊 Changes **18 files changed** (+820 additions, -158 deletions) <details> <summary>View changed files</summary> 📝 `cli/command/guest/guest-status.go` (+2 -2) 📝 `cli/command/guest/guest-uptime.go` (+3 -2) 📝 `proxmox/client.go` (+1 -0) 📝 `proxmox/config_guest.go` (+21 -21) 📝 `proxmox/config_guest_test.go` (+4 -4) 📝 `proxmox/config_lxc__features.go` (+5 -1) ➕ `proxmox/config_lxc__features_test.go` (+21 -0) 📝 `proxmox/config_lxc__mount.go` (+84 -23) 📝 `proxmox/config_lxc__mount_test.go` (+82 -0) 📝 `proxmox/config_lxc_new.go` (+171 -48) 📝 `proxmox/config_lxc_new_test.go` (+190 -43) 📝 `proxmox/config_qemu.go` (+8 -8) ➕ `proxmox/type_powerstate.go` (+40 -0) ➕ `proxmox/type_powerstate_test.go` (+77 -0) 📝 `proxmox/util.go` (+15 -6) 📝 `proxmox/util_test.go` (+8 -0) 📝 `proxmox/vmref.go` (+52 -0) 📝 `proxmox/vmref_test.go` (+36 -0) </details> ### 📄 Description While attempting to implement LXC mount I came across a lot of prerequisites that had to be implemented first. Instead of bloating that pr with all these prerequisites I'm merging it now. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>