[PR #426] [MERGED] Fix: Lxc network #461

New issue

Closed

opened 2026-02-28 00:42:17 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 00:42:17 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Telmate/proxmox-api-go/pull/426
Author: @Tinyblargon
Created: 6/17/2025
Status: ✅ Merged
Merged: 6/17/2025
Merged by: @Tinyblargon

Base: master ← Head: lxc-network

📝 Commits (6)

a6ce74d perf: reduce memory footprint
e436da6 feat: never return MAC as nil
843355b fix: deleted network always invalid
c9d3548 fix: can't unste address and gateway
276220f fix: duplicate check not accounting for deletion
fb31b4e test: missed code path

📊 Changes

3 files changed (+286 additions, -160 deletions)

View changed files

📝 proxmox/config_lxc__networks.go (+103 -69)
📝 proxmox/config_lxc__networks_test.go (+12 -0)
📝 proxmox/config_lxc_new_test.go (+171 -91)

📄 Description

Mostly bug fixes for the new LXC networks.
Set some properties that PVE will always return as never nil.
Reorganize structs to remove padding bytes.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Telmate/proxmox-api-go/pull/426 **Author:** [@Tinyblargon](https://github.com/Tinyblargon) **Created:** 6/17/2025 **Status:** ✅ Merged **Merged:** 6/17/2025 **Merged by:** [@Tinyblargon](https://github.com/Tinyblargon) **Base:** `master` ← **Head:** `lxc-network` --- ### 📝 Commits (6) - [`a6ce74d`](https://github.com/Telmate/proxmox-api-go/commit/a6ce74de6127fc3aadec7fe9fb1c3bb6507a3da0) perf: reduce memory footprint - [`e436da6`](https://github.com/Telmate/proxmox-api-go/commit/e436da6c29d6f2f6daab8bbd974eb0e35b1f4143) feat: never return MAC as nil - [`843355b`](https://github.com/Telmate/proxmox-api-go/commit/843355b766865528a723fca5c3067df547ddca1a) fix: deleted network always invalid - [`c9d3548`](https://github.com/Telmate/proxmox-api-go/commit/c9d354869e3815838d6624133fcc0847172530a0) fix: can't unste address and gateway - [`276220f`](https://github.com/Telmate/proxmox-api-go/commit/276220fc57ebe45efe003605a83d232d45e31428) fix: duplicate check not accounting for deletion - [`fb31b4e`](https://github.com/Telmate/proxmox-api-go/commit/fb31b4ec8468f9694132a2b06358b6de0fdf6f72) test: missed code path ### 📊 Changes **3 files changed** (+286 additions, -160 deletions) <details> <summary>View changed files</summary> 📝 `proxmox/config_lxc__networks.go` (+103 -69) 📝 `proxmox/config_lxc__networks_test.go` (+12 -0) 📝 `proxmox/config_lxc_new_test.go` (+171 -91) </details> ### 📄 Description Mostly bug fixes for the new LXC networks. Set some properties that PVE will always return as `never nil`. Reorganize structs to remove padding bytes. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>