[PR #392] [MERGED] feat: type NodeName #435

Closed
opened 2026-02-28 00:42:11 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/Telmate/proxmox-api-go/pull/392
Author: @Tinyblargon
Created: 12/28/2024
Status: Merged
Merged: 12/28/2024
Merged by: @Tinyblargon

Base: masterHead: #391


📝 Commits (1)

📊 Changes

10 files changed (+205 additions, -30 deletions)

View changed files

📝 main.go (+1 -1)
📝 proxmox/client.go (+15 -15)
📝 proxmox/config_guest.go (+3 -3)
📝 proxmox/config_lxc.go (+1 -1)
📝 proxmox/config_qemu.go (+4 -4)
📝 proxmox/data_qemu_agent.go (+1 -1)
📝 proxmox/node.go (+52 -0)
proxmox/node_test.go (+65 -0)
📝 proxmox/snapshot.go (+5 -5)
test/data/test_data_node/type_NodeName.go (+58 -0)

📄 Description

Closes #391

New code has 100% test coverage.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Telmate/proxmox-api-go/pull/392 **Author:** [@Tinyblargon](https://github.com/Tinyblargon) **Created:** 12/28/2024 **Status:** ✅ Merged **Merged:** 12/28/2024 **Merged by:** [@Tinyblargon](https://github.com/Tinyblargon) **Base:** `master` ← **Head:** `#391` --- ### 📝 Commits (1) - [`20d75e5`](https://github.com/Telmate/proxmox-api-go/commit/20d75e55413b8079897bc0bcedc5575a3d461569) feat: type `NodeName` ### 📊 Changes **10 files changed** (+205 additions, -30 deletions) <details> <summary>View changed files</summary> 📝 `main.go` (+1 -1) 📝 `proxmox/client.go` (+15 -15) 📝 `proxmox/config_guest.go` (+3 -3) 📝 `proxmox/config_lxc.go` (+1 -1) 📝 `proxmox/config_qemu.go` (+4 -4) 📝 `proxmox/data_qemu_agent.go` (+1 -1) 📝 `proxmox/node.go` (+52 -0) ➕ `proxmox/node_test.go` (+65 -0) 📝 `proxmox/snapshot.go` (+5 -5) ➕ `test/data/test_data_node/type_NodeName.go` (+58 -0) </details> ### 📄 Description Closes #391 New code has 100% test coverage. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-28 00:42:11 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/proxmox-api-go#435
No description provided.