[PR #389] Add `Task` Interface for long running functions #431

New issue

Open

opened 2026-02-28 00:42:11 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 00:42:11 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Telmate/proxmox-api-go/pull/389
Author: @Tinyblargon
Created: 12/7/2024
Status: 🔄 Open

Base: master ← Head: #388

📝 Commits (3)

ca4e9bb feat: implement Task interface
bbff06e Implement Task Interface where possible
d66b934 fix: ststiccheck SA1006

📊 Changes

15 files changed (+414 additions, -182 deletions)

View changed files

📝 cli/command/content/iso/download.go (+6 -1)
📝 cli/command/content/template/download.go (+6 -1)
📝 cli/command/create/create-snapshot.go (+7 -2)
📝 cli/command/delete/delete-file.go (+8 -3)
📝 cli/command/delete/delete.go (+5 -6)
📝 proxmox/client.go (+76 -115)
📝 proxmox/config_guest.go (+4 -5)
📝 proxmox/config_qemu.go (+17 -5)
📝 proxmox/config_qemu_disk.go (+13 -11)
📝 proxmox/content.go (+4 -4)
📝 proxmox/content_iso.go (+2 -6)
📝 proxmox/content_template.go (+2 -3)
📝 proxmox/session.go (+202 -0)
📝 proxmox/session_test.go (+39 -0)
📝 proxmox/snapshot.go (+23 -20)

📄 Description

Return a the new Task interface when we do something in the API that creates a longer running task in PVE.
Users can await this Task with WaitForCompletion().

Closes #388

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Telmate/proxmox-api-go/pull/389 **Author:** [@Tinyblargon](https://github.com/Tinyblargon) **Created:** 12/7/2024 **Status:** 🔄 Open **Base:** `master` ← **Head:** `#388` --- ### 📝 Commits (3) - [`ca4e9bb`](https://github.com/Telmate/proxmox-api-go/commit/ca4e9bb3949879a6fb34e41e2197f54924ff7868) feat: implement `Task` interface - [`bbff06e`](https://github.com/Telmate/proxmox-api-go/commit/bbff06ede8553eedb60d06d1ff8509a8c0d925ea) Implement `Task` Interface where possible - [`d66b934`](https://github.com/Telmate/proxmox-api-go/commit/d66b9348f1f8d0d92d5a1af1fcdf415b4c7031b1) fix: ststiccheck SA1006 ### 📊 Changes **15 files changed** (+414 additions, -182 deletions) <details> <summary>View changed files</summary> 📝 `cli/command/content/iso/download.go` (+6 -1) 📝 `cli/command/content/template/download.go` (+6 -1) 📝 `cli/command/create/create-snapshot.go` (+7 -2) 📝 `cli/command/delete/delete-file.go` (+8 -3) 📝 `cli/command/delete/delete.go` (+5 -6) 📝 `proxmox/client.go` (+76 -115) 📝 `proxmox/config_guest.go` (+4 -5) 📝 `proxmox/config_qemu.go` (+17 -5) 📝 `proxmox/config_qemu_disk.go` (+13 -11) 📝 `proxmox/content.go` (+4 -4) 📝 `proxmox/content_iso.go` (+2 -6) 📝 `proxmox/content_template.go` (+2 -3) 📝 `proxmox/session.go` (+202 -0) 📝 `proxmox/session_test.go` (+39 -0) 📝 `proxmox/snapshot.go` (+23 -20) </details> ### 📄 Description Return a the new `Task` interface when we do something in the API that creates a longer running task in PVE. Users can await this `Task` with `WaitForCompletion()`. Closes #388 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>