[PR #367] [MERGED] Fix: Create QEMU VMs directly in a configured Pool #423

Closed
opened 2026-02-28 00:42:08 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/Telmate/proxmox-api-go/pull/367
Author: @mpywell
Created: 10/17/2024
Status: Merged
Merged: 10/22/2024
Merged by: @Tinyblargon

Base: masterHead: exp/289


📝 Commits (2)

  • f3a833e Fix: Create QEMU VMs directly in a configured Pool
  • 94debce move pool config out of maptoAPI

📊 Changes

1 file changed (+5 additions, -5 deletions)

View changed files

📝 proxmox/config_qemu.go (+5 -5)

📄 Description

  • Reintroduced Pool for maptoAPI (required for creating a VM within a Pool)
  • Removed step to add to Pool after creating of a VM (errors 500 already a member of pool when Pool added to maptoAPI)
  • Added tests for maptoAPI for Pool

Closes #366


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Telmate/proxmox-api-go/pull/367 **Author:** [@mpywell](https://github.com/mpywell) **Created:** 10/17/2024 **Status:** ✅ Merged **Merged:** 10/22/2024 **Merged by:** [@Tinyblargon](https://github.com/Tinyblargon) **Base:** `master` ← **Head:** `exp/289` --- ### 📝 Commits (2) - [`f3a833e`](https://github.com/Telmate/proxmox-api-go/commit/f3a833e2e2a57bd1ae393a6ac4abd85e87b47ec3) Fix: Create QEMU VMs directly in a configured Pool - [`94debce`](https://github.com/Telmate/proxmox-api-go/commit/94debce1698f1a0f695f9fe45b7bfbe7e1cbe225) move pool config out of maptoAPI ### 📊 Changes **1 file changed** (+5 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `proxmox/config_qemu.go` (+5 -5) </details> ### 📄 Description - Reintroduced Pool for maptoAPI (required for creating a VM within a Pool) - Removed step to add to Pool after creating of a VM (errors `500 already a member of pool` when Pool added to maptoAPI) - Added tests for maptoAPI for Pool Closes #366 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-28 00:42:08 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/proxmox-api-go#423
No description provided.