[PR #368] [MERGED] tags - allow uppercase #422

New issue

Closed

opened 2026-02-28 00:42:08 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 00:42:08 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Telmate/proxmox-api-go/pull/368
Author: @xrayj11
Created: 10/20/2024
Status: ✅ Merged
Merged: 10/22/2024
Merged by: @Tinyblargon

Base: master ← Head: master

📝 Commits (1)

d5b3125 tags - allow uppercase

📊 Changes

2 files changed (+3 additions, -3 deletions)

View changed files

📝 proxmox/type_tag.go (+2 -2)
📝 test/data/test_data_tag/type_Tag.go (+1 -1)

📄 Description

Tags should be allowed to have uppercase letters.
There is an option in the Datacenter > Options > Tag Style Override to enforce case-sensitivity. When this is enabled, existing tags with capital letters cannot be assigned via this api.
I originally encountered this issue using Telmate/terraform-provider-proxmox, however it appears the root issue is in this repo which does tag validation:
github.com/Telmate/proxmox-api-go@25d65daa0b/proxmox/type_tag.go (L11-L16)
I think this should be a relatively simple fix, I've added A-Z to the regex, updated the error message, and moved a previously Illegal tag in the tests to the Legal list.
I've tested this change on my fork with createQemu, and it seems to be functioning as expected, I no longer receive an error trying to assign tags with uppercase characters.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Telmate/proxmox-api-go/pull/368 **Author:** [@xrayj11](https://github.com/xrayj11) **Created:** 10/20/2024 **Status:** ✅ Merged **Merged:** 10/22/2024 **Merged by:** [@Tinyblargon](https://github.com/Tinyblargon) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`d5b3125`](https://github.com/Telmate/proxmox-api-go/commit/d5b3125a2d216e155dbd1fb81d94ccfa012d524d) tags - allow uppercase ### 📊 Changes **2 files changed** (+3 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `proxmox/type_tag.go` (+2 -2) 📝 `test/data/test_data_tag/type_Tag.go` (+1 -1) </details> ### 📄 Description Tags should be allowed to have uppercase letters. There is an option in the Datacenter > Options > Tag Style Override to enforce case-sensitivity. When this is enabled, existing tags with capital letters cannot be assigned via this api. I originally encountered this issue using [Telmate/terraform-provider-proxmox](https://github.com/Telmate/terraform-provider-proxmox), however it appears the root issue is in this repo which does tag validation: https://github.com/Telmate/proxmox-api-go/blob/25d65daa0b88491c88653dbf897d87ff116c7f52/proxmox/type_tag.go#L11-L16 I think this should be a relatively simple fix, I've added A-Z to the regex, updated the error message, and moved a previously Illegal tag in the tests to the Legal list. I've tested this change on my fork with `createQemu`, and it seems to be functioning as expected, I no longer receive an error trying to assign tags with uppercase characters. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>