[PR #364] [MERGED] fix: do not expose empty cipassword to API #419

New issue

Closed

opened 2026-02-28 00:42:07 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 00:42:07 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Telmate/proxmox-api-go/pull/364
Author: @jay7x
Created: 9/12/2024
Status: ✅ Merged
Merged: 10/3/2024
Merged by: @Tinyblargon

Base: master ← Head: master

📝 Commits (3)

7ae7033 fix: do not expose empty cipassword to API
1962aad fix: delete cipassword when updated to empty value
3df2b32 test: add cipassword-related unit tests

📊 Changes

2 files changed (+12 additions, -2 deletions)

View changed files

📝 proxmox/config_qemu_cloudinit.go (+4 -1)
📝 proxmox/config_qemu_test.go (+8 -1)

📄 Description

Fixes https://github.com/Telmate/terraform-provider-proxmox/issues/1097

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Telmate/proxmox-api-go/pull/364 **Author:** [@jay7x](https://github.com/jay7x) **Created:** 9/12/2024 **Status:** ✅ Merged **Merged:** 10/3/2024 **Merged by:** [@Tinyblargon](https://github.com/Tinyblargon) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (3) - [`7ae7033`](https://github.com/Telmate/proxmox-api-go/commit/7ae7033ee0c09d7774f5211cc46faaf5ea8b4136) fix: do not expose empty cipassword to API - [`1962aad`](https://github.com/Telmate/proxmox-api-go/commit/1962aadae414c4f1098c0b1c8c06427d1ad52b73) fix: delete cipassword when updated to empty value - [`3df2b32`](https://github.com/Telmate/proxmox-api-go/commit/3df2b32281278d7c516802b7669f92a67dd0cf26) test: add cipassword-related unit tests ### 📊 Changes **2 files changed** (+12 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `proxmox/config_qemu_cloudinit.go` (+4 -1) 📝 `proxmox/config_qemu_test.go` (+8 -1) </details> ### 📄 Description Fixes https://github.com/Telmate/terraform-provider-proxmox/issues/1097 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>