[PR #351] [MERGED] Fix README.md #410

New issue

Closed

opened 2026-02-28 00:42:05 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 00:42:05 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Telmate/proxmox-api-go/pull/351
Author: @OidaTiftla
Created: 8/11/2024
Status: ✅ Merged
Merged: 8/19/2024
Merged by: @Tinyblargon

Base: master ← Head: fix-docu

📝 Commits (2)

81522e0 fix: typo in README.md
d21cfeb docs: 📝 update JSON samples for VM creation and clone

📊 Changes

1 file changed (+128 additions, -23 deletions)

View changed files

📝 README.md (+128 -23)

📄 Description

I noticed the README.md seems some kind of outdated.

I tried to update the portions I could test.

createQemu JSON Sample
cloneQemu JSON Sample
cloneQemu cloud-init JSON Sample

What I could not test in the createQemu JSON Sample:

needed to remove the rng0 section:
- error creating VM: 500 only root can set 'rng0' config
needed to remove the usb0 section:
- error creating VM: 500 only root can set 'usb0' config for real devices
needed to remove the network section:
- error creating VM: 500 no sdn vnet ID specified
the disk section did not throw any errors, but the created VM also did not have the specified disk, maybe because I did not have a storage_type as dir configured?

I hope this helps the project. And if there is anything I can improve in this PR, I will appreciate your feedback.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Telmate/proxmox-api-go/pull/351 **Author:** [@OidaTiftla](https://github.com/OidaTiftla) **Created:** 8/11/2024 **Status:** ✅ Merged **Merged:** 8/19/2024 **Merged by:** [@Tinyblargon](https://github.com/Tinyblargon) **Base:** `master` ← **Head:** `fix-docu` --- ### 📝 Commits (2) - [`81522e0`](https://github.com/Telmate/proxmox-api-go/commit/81522e011cbed5589ba86195d919fe92d50213c5) fix: typo in README.md - [`d21cfeb`](https://github.com/Telmate/proxmox-api-go/commit/d21cfebeb054debcf26f7bea8f7a5c9a1ba8d44d) docs: :memo: update JSON samples for VM creation and clone ### 📊 Changes **1 file changed** (+128 additions, -23 deletions) <details> <summary>View changed files</summary> 📝 `README.md` (+128 -23) </details> ### 📄 Description I noticed the README.md seems some kind of outdated. I tried to update the portions I could test. - `createQemu JSON Sample` - `cloneQemu JSON Sample` - `cloneQemu cloud-init JSON Sample` What I could not test in the `createQemu JSON Sample`: - needed to remove the `rng0` section: - `error creating VM: 500 only root can set 'rng0' config` - needed to remove the `usb0` section: - `error creating VM: 500 only root can set 'usb0' config for real devices` - needed to remove the `network` section: - `error creating VM: 500 no sdn vnet ID specified` - the disk section did not throw any errors, but the created VM also did not have the specified disk, maybe because I did not have a `storage_type` as `dir` configured? I hope this helps the project. And if there is anything I can improve in this PR, I will appreciate your feedback. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>