[PR #342] [MERGED] fix: dashes in tags allowed everywhere but at the start of tag #402

New issue

Closed

opened 2026-02-28 00:42:03 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 00:42:03 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Telmate/proxmox-api-go/pull/342
Author: @TarasJan
Created: 6/14/2024
Status: ✅ Merged
Merged: 6/15/2024
Merged by: @Tinyblargon

Base: master ← Head: fix/tags_with_dash

📝 Commits (1)

252795c fix: dashes in tags allowed everywhere but at the start of tag

📊 Changes

2 files changed (+4 additions, -3 deletions)

View changed files

📝 proxmox/type_tag.go (+2 -2)
📝 test/data/test_data_tag/type_Tag.go (+2 -1)

📄 Description

Issue

https://github.com/Telmate/proxmox-api-go/issues/340

Tags now are allowed to have dash in every, but first character.

Comment

Kept original invalid formatting error and modifying regex to limit logic branching as much as possible, added red, green example to existing tag tests.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Telmate/proxmox-api-go/pull/342 **Author:** [@TarasJan](https://github.com/TarasJan) **Created:** 6/14/2024 **Status:** ✅ Merged **Merged:** 6/15/2024 **Merged by:** [@Tinyblargon](https://github.com/Tinyblargon) **Base:** `master` ← **Head:** `fix/tags_with_dash` --- ### 📝 Commits (1) - [`252795c`](https://github.com/Telmate/proxmox-api-go/commit/252795ce346c6e7b7835357a54709d6bdd284916) fix: dashes in tags allowed everywhere but at the start of tag ### 📊 Changes **2 files changed** (+4 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `proxmox/type_tag.go` (+2 -2) 📝 `test/data/test_data_tag/type_Tag.go` (+2 -1) </details> ### 📄 Description ## Issue https://github.com/Telmate/proxmox-api-go/issues/340 Tags now are allowed to have dash in every, but first character. ## Comment Kept original invalid formatting error and modifying regex to limit logic branching as much as possible, added red, green example to existing tag tests. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>