[PR #335] [MERGED] Overhaul: pool #400

New issue

Closed

opened 2026-02-28 00:42:03 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 00:42:03 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Telmate/proxmox-api-go/pull/335
Author: @Tinyblargon
Created: 5/25/2024
Status: ✅ Merged
Merged: 5/25/2024
Merged by: @Tinyblargon

Base: master ← Head: Overhaul-Pool

📝 Commits (10+)

0322143 feat: type ConfigPool
822c076 test: PoolName validate
20d1373 feat: ListPools()
61e99e1 feat: check pool existence
8efaa23 feat: delete pool
121b5d0 feat: get pool from api
044ab4c feat: remove pool guests
581d01c feat: add guests to pool
2a4d1ca feat: set pool guests
ea3cc0b feat: pool create and update

📊 Changes

18 files changed (+1043 additions, -41 deletions)

View changed files

📝 cli/command/create/create-pool.go (+7 -3)
📝 cli/command/delete/delete.go (+1 -1)
📝 cli/command/list/list-pools.go (+10 -2)
📝 cli/command/list/list.go (+0 -2)
📝 cli/command/update/update-poolcomment.go (+7 -3)
📝 main.go (+10 -7)
📝 proxmox/client.go (+9 -0)
📝 proxmox/config_guest.go (+36 -2)
📝 proxmox/config_lxc.go (+1 -1)
➕ proxmox/config_pool.go (+457 -0)
➕ proxmox/config_pool_test.go (+370 -0)
📝 proxmox/config_qemu.go (+34 -11)
📝 proxmox/config_qemu_test.go (+19 -6)
📝 proxmox/util.go (+14 -0)
📝 proxmox/util_test.go (+29 -0)
📝 test/api/Pool/pool_create_destroy_test.go (+3 -2)
📝 test/api/Pool/pool_list_test.go (+2 -1)
➕ test/data/test_data_pool/type_PoolName.go (+34 -0)

📄 Description

Re-implemented pools.

You can now set which guests should be member's of a pool.
It returns properly defined structs.
Everything has tests.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Telmate/proxmox-api-go/pull/335 **Author:** [@Tinyblargon](https://github.com/Tinyblargon) **Created:** 5/25/2024 **Status:** ✅ Merged **Merged:** 5/25/2024 **Merged by:** [@Tinyblargon](https://github.com/Tinyblargon) **Base:** `master` ← **Head:** `Overhaul-Pool` --- ### 📝 Commits (10+) - [`0322143`](https://github.com/Telmate/proxmox-api-go/commit/03221436f01877eb550f8a854fc4f2d3355203af) feat: type `ConfigPool` - [`822c076`](https://github.com/Telmate/proxmox-api-go/commit/822c076fb19be87e696e893efcbb5789ff79ca5a) test: `PoolName` validate - [`20d1373`](https://github.com/Telmate/proxmox-api-go/commit/20d137342fb385ecc7461506d7c94a1068bb3c5a) feat: `ListPools()` - [`61e99e1`](https://github.com/Telmate/proxmox-api-go/commit/61e99e1d61e79aa436ed636dafa3e5d95734753c) feat: check pool existence - [`8efaa23`](https://github.com/Telmate/proxmox-api-go/commit/8efaa233c15c43b2442c2a7fe4ddead82b524f4b) feat: delete pool - [`121b5d0`](https://github.com/Telmate/proxmox-api-go/commit/121b5d0f6ef73a77edaacf77e79eba6a40008e7f) feat: get `pool` from api - [`044ab4c`](https://github.com/Telmate/proxmox-api-go/commit/044ab4c9873e0ad23466f52c779911936466453e) feat: remove pool guests - [`581d01c`](https://github.com/Telmate/proxmox-api-go/commit/581d01c340de2c0c6780636dd6e65e5eb939feb1) feat: add guests to pool - [`2a4d1ca`](https://github.com/Telmate/proxmox-api-go/commit/2a4d1ca7cdf25a99db001b9242034e0a9f72ca6a) feat: set pool guests - [`ea3cc0b`](https://github.com/Telmate/proxmox-api-go/commit/ea3cc0bc9960877a4cab5aa19dbfaa1ea125a0d9) feat: pool create and update ### 📊 Changes **18 files changed** (+1043 additions, -41 deletions) <details> <summary>View changed files</summary> 📝 `cli/command/create/create-pool.go` (+7 -3) 📝 `cli/command/delete/delete.go` (+1 -1) 📝 `cli/command/list/list-pools.go` (+10 -2) 📝 `cli/command/list/list.go` (+0 -2) 📝 `cli/command/update/update-poolcomment.go` (+7 -3) 📝 `main.go` (+10 -7) 📝 `proxmox/client.go` (+9 -0) 📝 `proxmox/config_guest.go` (+36 -2) 📝 `proxmox/config_lxc.go` (+1 -1) ➕ `proxmox/config_pool.go` (+457 -0) ➕ `proxmox/config_pool_test.go` (+370 -0) 📝 `proxmox/config_qemu.go` (+34 -11) 📝 `proxmox/config_qemu_test.go` (+19 -6) 📝 `proxmox/util.go` (+14 -0) 📝 `proxmox/util_test.go` (+29 -0) 📝 `test/api/Pool/pool_create_destroy_test.go` (+3 -2) 📝 `test/api/Pool/pool_list_test.go` (+2 -1) ➕ `test/data/test_data_pool/type_PoolName.go` (+34 -0) </details> ### 📄 Description Re-implemented pools. You can now set which guests should be member's of a pool. It returns properly defined structs. Everything has tests. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>