[PR #332] [MERGED] Overhaul: Guest tags #397

New issue

Closed

opened 2026-02-28 00:42:02 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 00:42:02 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Telmate/proxmox-api-go/pull/332
Author: @Tinyblargon
Created: 4/27/2024
Status: ✅ Merged
Merged: 5/15/2024
Merged by: @Tinyblargon

Base: master ← Head: Overhaul#331

📝 Commits (2)

526974e feat: Tag type
e3e41c0 feat: use []Tag type

📊 Changes

7 files changed (+239 additions, -11 deletions)

View changed files

📝 proxmox/config_guest.go (+2 -3)
📝 proxmox/config_guest_test.go (+4 -4)
📝 proxmox/config_qemu.go (+10 -4)
📝 proxmox/config_qemu_test.go (+44 -0)
➕ proxmox/type_tag.go (+70 -0)
➕ proxmox/type_tag_test.go (+41 -0)
➕ test/data/test_data_tag/type_Tag.go (+68 -0)

📄 Description

Added Tag type with validation logic.
Replaced all instances where string was used for tags with []Tag, (except in LXC)
Added test for everything.

Fixes #331

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Telmate/proxmox-api-go/pull/332 **Author:** [@Tinyblargon](https://github.com/Tinyblargon) **Created:** 4/27/2024 **Status:** ✅ Merged **Merged:** 5/15/2024 **Merged by:** [@Tinyblargon](https://github.com/Tinyblargon) **Base:** `master` ← **Head:** `Overhaul#331` --- ### 📝 Commits (2) - [`526974e`](https://github.com/Telmate/proxmox-api-go/commit/526974e527f1516675fa01ec78d72bd61e08d256) feat: `Tag` type - [`e3e41c0`](https://github.com/Telmate/proxmox-api-go/commit/e3e41c00cccfa63ba165b5a529f3952ce8975bc7) feat: use `[]Tag` type ### 📊 Changes **7 files changed** (+239 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `proxmox/config_guest.go` (+2 -3) 📝 `proxmox/config_guest_test.go` (+4 -4) 📝 `proxmox/config_qemu.go` (+10 -4) 📝 `proxmox/config_qemu_test.go` (+44 -0) ➕ `proxmox/type_tag.go` (+70 -0) ➕ `proxmox/type_tag_test.go` (+41 -0) ➕ `test/data/test_data_tag/type_Tag.go` (+68 -0) </details> ### 📄 Description - Added `Tag` type with validation logic. - Replaced all instances where `string` was used for tags with `[]Tag`, (except in LXC) - Added test for everything. Fixes #331 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>