[PR #327] [MERGED] Overhaul: Qemu Guest Agent #396

New issue

Closed

opened 2026-02-28 00:42:02 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 00:42:02 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Telmate/proxmox-api-go/pull/327
Author: @Tinyblargon
Created: 4/15/2024
Status: ✅ Merged
Merged: 4/18/2024
Merged by: @Tinyblargon

Base: master ← Head: Overhaul#323

📝 Commits (4)

1b29c0f test: QemuGuestAgent
7ab5a33 feat: func boolToIntString()
1a18758 feat: QemuGuestAgent
ff84c23 fix: QemuGuestAgentType can be unset

📊 Changes

5 files changed (+342 additions, -64 deletions)

View changed files

📝 proxmox/config_qemu.go (+63 -64)
➕ proxmox/config_qemu_guestagent.go (+94 -0)
➕ proxmox/config_qemu_guestagent_test.go (+51 -0)
📝 proxmox/config_qemu_test.go (+126 -0)
📝 proxmox/util.go (+8 -0)

📄 Description

Fixes #323

Re-implements the QemuGuestAgent as the current version of proxmox has more options than disable and enable:

type QemuGuestAgent struct {
	Enable *bool               `json:"enable,omitempty"` // Optional
	Type   *QemuGuestAgentType `json:"type,omitempty"`   // Optional
	Freeze *bool               `json:"freeze,omitempty"` // Optional
	FsTrim *bool               `json:"trim,omitempty"`   // Optional
}

I'll fix this downstream in the Terraform provider as well.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Telmate/proxmox-api-go/pull/327 **Author:** [@Tinyblargon](https://github.com/Tinyblargon) **Created:** 4/15/2024 **Status:** ✅ Merged **Merged:** 4/18/2024 **Merged by:** [@Tinyblargon](https://github.com/Tinyblargon) **Base:** `master` ← **Head:** `Overhaul#323` --- ### 📝 Commits (4) - [`1b29c0f`](https://github.com/Telmate/proxmox-api-go/commit/1b29c0fffa7dd52c4ed4196dc29e2dea9ebfd426) test: `QemuGuestAgent` - [`7ab5a33`](https://github.com/Telmate/proxmox-api-go/commit/7ab5a3320dbf374fab49a5cf77b9264985e71908) feat: func `boolToIntString()` - [`1a18758`](https://github.com/Telmate/proxmox-api-go/commit/1a187586392e6dcf7cb71bc2a2c80b2d99c33533) feat: `QemuGuestAgent` - [`ff84c23`](https://github.com/Telmate/proxmox-api-go/commit/ff84c237c6403c8cab45e04e1406e24888e361c3) fix: `QemuGuestAgentType` can be unset ### 📊 Changes **5 files changed** (+342 additions, -64 deletions) <details> <summary>View changed files</summary> 📝 `proxmox/config_qemu.go` (+63 -64) ➕ `proxmox/config_qemu_guestagent.go` (+94 -0) ➕ `proxmox/config_qemu_guestagent_test.go` (+51 -0) 📝 `proxmox/config_qemu_test.go` (+126 -0) 📝 `proxmox/util.go` (+8 -0) </details> ### 📄 Description Fixes #323 Re-implements the QemuGuestAgent as the current version of proxmox has more options than disable and enable: ```go type QemuGuestAgent struct { Enable *bool `json:"enable,omitempty"` // Optional Type *QemuGuestAgentType `json:"type,omitempty"` // Optional Freeze *bool `json:"freeze,omitempty"` // Optional FsTrim *bool `json:"trim,omitempty"` // Optional } ``` I'll fix this downstream in the Terraform provider as well. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>