[PR #326] Include ConfigQemu.Agent when creating params struct even when 0 #395

New issue

Open

opened 2026-02-28 00:42:01 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 00:42:01 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Telmate/proxmox-api-go/pull/326
Author: @mollstam
Created: 4/11/2024
Status: 🔄 Open

Base: master ← Head: fix/config-qemu-agent

📝 Commits (1)

db6a15f fix to not emit "agent" from params when 0

📊 Changes

1 file changed (+2 additions, -3 deletions)

View changed files

📝 proxmox/config_qemu.go (+2 -3)

📄 Description

The current code does not set params["agent"] to 0 when set to 0 in ConfigQemu.Agent, erroneously identifying 0 as "no value", making it never possible to e.g. update from agent 1 to 0. I believe this is an error, let me know if not. 😬

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Telmate/proxmox-api-go/pull/326 **Author:** [@mollstam](https://github.com/mollstam) **Created:** 4/11/2024 **Status:** 🔄 Open **Base:** `master` ← **Head:** `fix/config-qemu-agent` --- ### 📝 Commits (1) - [`db6a15f`](https://github.com/Telmate/proxmox-api-go/commit/db6a15f249ef7e1f195e7ac2ada9e8c27aa57dc8) fix to not emit "agent" from params when 0 ### 📊 Changes **1 file changed** (+2 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `proxmox/config_qemu.go` (+2 -3) </details> ### 📄 Description The current code does not set `params["agent"]` to `0` when set to `0` in `ConfigQemu.Agent`, erroneously identifying `0` as "no value", making it never possible to e.g. update from agent `1` to `0`. I believe this is an error, let me know if not. 😬 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>