[PR #324] [MERGED] Remove old qemu create and update #394

Closed
opened 2026-02-28 00:42:01 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/Telmate/proxmox-api-go/pull/324
Author: @Tinyblargon
Created: 3/18/2024
Status: Merged
Merged: 4/9/2024
Merged by: @Tinyblargon

Base: masterHead: Remove#310


📝 Commits (1)

  • ba3f544 Remove old qemu create and update

📊 Changes

7 files changed (+11 additions, -326 deletions)

View changed files

📝 cli/command/create/guest/create-guest.go (+1 -1)
📝 main.go (+4 -3)
📝 proxmox/config_qemu.go (+0 -316)
📝 test/api/CloudInit/cloudinit_test.go (+2 -2)
📝 test/api/Qemu/qemu_clone_test.go (+1 -1)
📝 test/api/Qemu/qemu_create_update_delete_test.go (+2 -2)
📝 test/api/Qemu/qemu_start_test.go (+1 -1)

📄 Description

Removes the old qemu create and update code.
The integration test for qemu are a bit broken. I'll fix this in another PR, as i want to overhaul the testing framework.

Closes #310


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Telmate/proxmox-api-go/pull/324 **Author:** [@Tinyblargon](https://github.com/Tinyblargon) **Created:** 3/18/2024 **Status:** ✅ Merged **Merged:** 4/9/2024 **Merged by:** [@Tinyblargon](https://github.com/Tinyblargon) **Base:** `master` ← **Head:** `Remove#310` --- ### 📝 Commits (1) - [`ba3f544`](https://github.com/Telmate/proxmox-api-go/commit/ba3f544db26d7bdbb659b39788cea642bc2c9caa) Remove old qemu create and update ### 📊 Changes **7 files changed** (+11 additions, -326 deletions) <details> <summary>View changed files</summary> 📝 `cli/command/create/guest/create-guest.go` (+1 -1) 📝 `main.go` (+4 -3) 📝 `proxmox/config_qemu.go` (+0 -316) 📝 `test/api/CloudInit/cloudinit_test.go` (+2 -2) 📝 `test/api/Qemu/qemu_clone_test.go` (+1 -1) 📝 `test/api/Qemu/qemu_create_update_delete_test.go` (+2 -2) 📝 `test/api/Qemu/qemu_start_test.go` (+1 -1) </details> ### 📄 Description Removes the old qemu create and update code. The integration test for qemu are a bit broken. I'll fix this in another PR, as i want to overhaul the testing framework. Closes #310 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-28 00:42:01 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/proxmox-api-go#394
No description provided.