mirror of
https://github.com/Telmate/proxmox-api-go.git
synced 2026-04-25 15:35:51 +03:00
[PR #313] [MERGED] Snapshot addons #386
Labels
No labels
good first issue
issue/confirmed
issue/critical
proposal/accepted
pull-request
type/bug
type/enhancement
type/feature
type/question
type/refactoring
type/testing
type/testing
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/proxmox-api-go#386
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/Telmate/proxmox-api-go/pull/313
Author: @Tinyblargon
Created: 2/29/2024
Status: ✅ Merged
Merged: 3/9/2024
Merged by: @Tinyblargon
Base:
master← Head:snapshot-addon📝 Commits (9)
50b2637feat: addSnapshotName.Delete()9739d34feat: addSnapshotName.Rollback()8c93ee1fix: incorrect typeseee8b3efeat: add unsafe create for snapshots8943618feat: addunsafefunctions8998878fix: addSnapshotName.UpdateDescription()62814ecfix: snapshot name not validatedbb6e576refactor: inline errorsc3aa491refactor: use functions ofSnapshotName📊 Changes
6 files changed (+80 additions, -39 deletions)
View changed files
📝
cli/command/create/create-snapshot.go(+1 -1)📝
cli/command/delete/delete-snapshot.go(+1 -1)📝
cli/command/guest/guest-rollback.go(+1 -1)📝
cli/command/update/update-snapshotdescription.go(+1 -1)📝
proxmox/client.go(+1 -1)📝
proxmox/snapshot.go(+75 -34)📄 Description
Added some features for working with snapshots.
Moved 3 functions from global to local behaviors,
SnapshotName.Delete(),SnapshotName.UpdateDescription()andSnapshotName.Rollback(). Also added theirunsafeequivalents.The old functions now call these new ones.
Added
ConfigSnapshot.Create()andConfigSnapshot.Create_Unsafe(), and deprecated the oldCreateSnapshot().🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.