[PR #313] [MERGED] Snapshot addons #386

Closed
opened 2026-02-28 00:42:00 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/Telmate/proxmox-api-go/pull/313
Author: @Tinyblargon
Created: 2/29/2024
Status: Merged
Merged: 3/9/2024
Merged by: @Tinyblargon

Base: masterHead: snapshot-addon


📝 Commits (9)

  • 50b2637 feat: add SnapshotName.Delete()
  • 9739d34 feat: add SnapshotName.Rollback()
  • 8c93ee1 fix: incorrect types
  • eee8b3e feat: add unsafe create for snapshots
  • 8943618 feat: add unsafe functions
  • 8998878 fix: add SnapshotName.UpdateDescription()
  • 62814ec fix: snapshot name not validated
  • bb6e576 refactor: inline errors
  • c3aa491 refactor: use functions of SnapshotName

📊 Changes

6 files changed (+80 additions, -39 deletions)

View changed files

📝 cli/command/create/create-snapshot.go (+1 -1)
📝 cli/command/delete/delete-snapshot.go (+1 -1)
📝 cli/command/guest/guest-rollback.go (+1 -1)
📝 cli/command/update/update-snapshotdescription.go (+1 -1)
📝 proxmox/client.go (+1 -1)
📝 proxmox/snapshot.go (+75 -34)

📄 Description

Added some features for working with snapshots.

Moved 3 functions from global to local behaviors, SnapshotName.Delete(), SnapshotName.UpdateDescription() and SnapshotName.Rollback(). Also added their unsafe equivalents.
The old functions now call these new ones.

Added ConfigSnapshot.Create() and ConfigSnapshot.Create_Unsafe(), and deprecated the old CreateSnapshot().


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Telmate/proxmox-api-go/pull/313 **Author:** [@Tinyblargon](https://github.com/Tinyblargon) **Created:** 2/29/2024 **Status:** ✅ Merged **Merged:** 3/9/2024 **Merged by:** [@Tinyblargon](https://github.com/Tinyblargon) **Base:** `master` ← **Head:** `snapshot-addon` --- ### 📝 Commits (9) - [`50b2637`](https://github.com/Telmate/proxmox-api-go/commit/50b2637779d0a821ddd6b91624a6289d1d99e1ca) feat: add `SnapshotName.Delete()` - [`9739d34`](https://github.com/Telmate/proxmox-api-go/commit/9739d3430056f8df81c12ba53e95acbf72b1f50a) feat: add `SnapshotName.Rollback()` - [`8c93ee1`](https://github.com/Telmate/proxmox-api-go/commit/8c93ee1ec56e622b0247d0755319873a8e6e026d) fix: incorrect types - [`eee8b3e`](https://github.com/Telmate/proxmox-api-go/commit/eee8b3e0428b5f008817d41ae97ff35d3234f309) feat: add unsafe create for snapshots - [`8943618`](https://github.com/Telmate/proxmox-api-go/commit/8943618d6d658a5c388e02465b32a9528880e11b) feat: add `unsafe` functions - [`8998878`](https://github.com/Telmate/proxmox-api-go/commit/89988786c74b6825eb4dad3281d669002d6866ad) fix: add `SnapshotName.UpdateDescription()` - [`62814ec`](https://github.com/Telmate/proxmox-api-go/commit/62814ec3ca43cf60f23a6a85339eccf743441a13) fix: snapshot name not validated - [`bb6e576`](https://github.com/Telmate/proxmox-api-go/commit/bb6e5765703ecd9142583b63946ffd215d103d64) refactor: inline errors - [`c3aa491`](https://github.com/Telmate/proxmox-api-go/commit/c3aa49177d2100cfcc83552b830094b49c138fc8) refactor: use functions of `SnapshotName` ### 📊 Changes **6 files changed** (+80 additions, -39 deletions) <details> <summary>View changed files</summary> 📝 `cli/command/create/create-snapshot.go` (+1 -1) 📝 `cli/command/delete/delete-snapshot.go` (+1 -1) 📝 `cli/command/guest/guest-rollback.go` (+1 -1) 📝 `cli/command/update/update-snapshotdescription.go` (+1 -1) 📝 `proxmox/client.go` (+1 -1) 📝 `proxmox/snapshot.go` (+75 -34) </details> ### 📄 Description Added some features for working with snapshots. Moved 3 functions from global to local behaviors, `SnapshotName.Delete()`, `SnapshotName.UpdateDescription()` and `SnapshotName.Rollback()`. Also added their `unsafe` equivalents. The old functions now call these new ones. Added `ConfigSnapshot.Create()` and `ConfigSnapshot.Create_Unsafe()`, and deprecated the old `CreateSnapshot()`. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-28 00:42:00 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/proxmox-api-go#386
No description provided.