[PR #305] [MERGED] Feature: Disk size in Kibibyte #383

New issue

Closed

opened 2026-02-28 00:41:59 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 00:41:59 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Telmate/proxmox-api-go/pull/305
Author: @Tinyblargon
Created: 1/31/2024
Status: ✅ Merged
Merged: 2/5/2024
Merged by: @Tinyblargon

Base: master ← Head: Feature#304

📝 Commits (9)

189aa8d test: update for Kibibyte size
69e86d5 feat: disk size in K M G T
651e9e2 feat: Resize disk in Kibibyte
2bd32a2 refactor: extract disk resize loop to func
7c468ba feat: build list of disk to resize
2dd9a87 feat: resize disks that where created with 0 size
100a85b refactor: rename Size to SizeInKibibytes
f32d302 fix: disk value may not be 0
917baef feat: type QemuDiskSize

📊 Changes

8 files changed (+2229 additions, -1391 deletions)

View changed files

📝 proxmox/config_qemu.go (+9 -5)
📝 proxmox/config_qemu_disk.go (+128 -43)
📝 proxmox/config_qemu_disk_ide.go (+90 -70)
📝 proxmox/config_qemu_disk_sata.go (+88 -70)
📝 proxmox/config_qemu_disk_scsi.go (+98 -80)
📝 proxmox/config_qemu_disk_test.go (+243 -66)
📝 proxmox/config_qemu_disk_virtio.go (+93 -75)
📝 proxmox/config_qemu_test.go (+1480 -982)

📄 Description

Changes the size of all disk to be in Kibibytes instead of Gibibytes. Closes #304

Work done:

Added test for new functions.
Added a resize step to the Qemu create and update workflow.
Renamed Size variable (big commit at the end)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Telmate/proxmox-api-go/pull/305 **Author:** [@Tinyblargon](https://github.com/Tinyblargon) **Created:** 1/31/2024 **Status:** ✅ Merged **Merged:** 2/5/2024 **Merged by:** [@Tinyblargon](https://github.com/Tinyblargon) **Base:** `master` ← **Head:** `Feature#304` --- ### 📝 Commits (9) - [`189aa8d`](https://github.com/Telmate/proxmox-api-go/commit/189aa8de30bfeb265bd364925da2eb8362fb8598) test: update for Kibibyte size - [`69e86d5`](https://github.com/Telmate/proxmox-api-go/commit/69e86d5499d6bd59c6fae2cd7fad619d27f0ff85) feat: disk size in K M G T - [`651e9e2`](https://github.com/Telmate/proxmox-api-go/commit/651e9e2838e554b24dcc34141d4db0117dffbf6f) feat: Resize disk in Kibibyte - [`2bd32a2`](https://github.com/Telmate/proxmox-api-go/commit/2bd32a2988df6ca8be00dadd48e9a676a8709631) refactor: extract disk resize loop to func - [`7c468ba`](https://github.com/Telmate/proxmox-api-go/commit/7c468ba56f87d53c18ec2747b4cf3d12c9b05238) feat: build list of disk to resize - [`2dd9a87`](https://github.com/Telmate/proxmox-api-go/commit/2dd9a878846485fe39a388c395ee13e532cbd226) feat: resize disks that where created with 0 size - [`100a85b`](https://github.com/Telmate/proxmox-api-go/commit/100a85b2a4d5dac50f260859c4ebd5018eef8b59) refactor: rename `Size` to `SizeInKibibytes` - [`f32d302`](https://github.com/Telmate/proxmox-api-go/commit/f32d3029f037b6c20a30e758bc603e9093dfc200) fix: disk value may not be `0` - [`917baef`](https://github.com/Telmate/proxmox-api-go/commit/917baef1800c9e5d3e8f9c97e5aa50cd1523e2bd) feat: type `QemuDiskSize` ### 📊 Changes **8 files changed** (+2229 additions, -1391 deletions) <details> <summary>View changed files</summary> 📝 `proxmox/config_qemu.go` (+9 -5) 📝 `proxmox/config_qemu_disk.go` (+128 -43) 📝 `proxmox/config_qemu_disk_ide.go` (+90 -70) 📝 `proxmox/config_qemu_disk_sata.go` (+88 -70) 📝 `proxmox/config_qemu_disk_scsi.go` (+98 -80) 📝 `proxmox/config_qemu_disk_test.go` (+243 -66) 📝 `proxmox/config_qemu_disk_virtio.go` (+93 -75) 📝 `proxmox/config_qemu_test.go` (+1480 -982) </details> ### 📄 Description Changes the size of all disk to be in Kibibytes instead of Gibibytes. Closes #304 Work done: - Added test for new functions. - Added a resize step to the Qemu create and update workflow. - Renamed `Size variable` (big commit at the end) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>