[PR #290] [MERGED] Bug fix: `ConfigQemu`. `Node`, `Pool`, `VmID` #373

New issue

Closed

opened 2026-02-28 00:41:56 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 00:41:56 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Telmate/proxmox-api-go/pull/290
Author: @Tinyblargon
Created: 12/18/2023
Status: ✅ Merged
Merged: 12/21/2023
Merged by: @mleone87

Base: master ← Head: BugFix-Qemu-Pool2

📝 Commits (2)

b7f345d test: added for Node, Pool, VmID
23f299e fix: Node, Pool, VmID are never set

📊 Changes

2 files changed (+46 additions, -3 deletions)

View changed files

📝 proxmox/config_qemu.go (+8 -2)
📝 proxmox/config_qemu_test.go (+38 -1)

📄 Description

Noticed that #255 broke ConfigQemu. Node, Pool, VmID

Work Done:

Fixed bug
Added unit test

Rework of #272

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Telmate/proxmox-api-go/pull/290 **Author:** [@Tinyblargon](https://github.com/Tinyblargon) **Created:** 12/18/2023 **Status:** ✅ Merged **Merged:** 12/21/2023 **Merged by:** [@mleone87](https://github.com/mleone87) **Base:** `master` ← **Head:** `BugFix-Qemu-Pool2` --- ### 📝 Commits (2) - [`b7f345d`](https://github.com/Telmate/proxmox-api-go/commit/b7f345d56099213bbd32535f4d7f4bead08b5063) test: added for `Node`, `Pool`, `VmID` - [`23f299e`](https://github.com/Telmate/proxmox-api-go/commit/23f299e7b788dba1a923544ee8a31b25e315f18f) fix: `Node`, `Pool`, `VmID` are never set ### 📊 Changes **2 files changed** (+46 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `proxmox/config_qemu.go` (+8 -2) 📝 `proxmox/config_qemu_test.go` (+38 -1) </details> ### 📄 Description Noticed that #255 broke `ConfigQemu`. `Node`, `Pool`, `VmID` Work Done: - Fixed bug - Added unit test Rework of #272 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>