[PR #272] [CLOSED] Bug fix: `ConfigQemu`. `Node`, `Pool`, `VmID` #360

New issue

Closed

opened 2026-02-28 00:41:53 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 00:41:53 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Telmate/proxmox-api-go/pull/272
Author: @Tinyblargon
Created: 7/14/2023
Status: ❌ Closed

Base: master ← Head: BugFix-Qemu-Pool

📝 Commits (3)

f5eb43d refactor: update test to improve readability
761523a test: added for Node, Pool, VmID
a752d22 fix: Node, Pool, VmID are never set

📊 Changes

2 files changed (+2112 additions, -2047 deletions)

View changed files

📝 proxmox/config_qemu.go (+8 -2)
📝 proxmox/config_qemu_test.go (+2104 -2045)

📄 Description

Noticed that #255 broke ConfigQemu. Node, Pool, VmID

Work Done:

Fixed bug a752d2201e
Added unit test 761523a724
Changed structure of existing unit test to allow for easier extension f5eb43dfad. The change was nesting all existing Disk tests into an array item so each top level parameter in ConfigQemu has it's own array entry. This way the item containing the Disk tasks can be collapsed making the test more readable.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Telmate/proxmox-api-go/pull/272 **Author:** [@Tinyblargon](https://github.com/Tinyblargon) **Created:** 7/14/2023 **Status:** ❌ Closed **Base:** `master` ← **Head:** `BugFix-Qemu-Pool` --- ### 📝 Commits (3) - [`f5eb43d`](https://github.com/Telmate/proxmox-api-go/commit/f5eb43dfade238b7836d26096ee2d6ce88d6e57d) refactor: update test to improve readability - [`761523a`](https://github.com/Telmate/proxmox-api-go/commit/761523a724cda6c3e7aa31f658498799071258d9) test: added for `Node`, `Pool`, `VmID` - [`a752d22`](https://github.com/Telmate/proxmox-api-go/commit/a752d2201e949d272f94a2a1b5ddf81122330223) fix: `Node`, `Pool`, `VmID` are never set ### 📊 Changes **2 files changed** (+2112 additions, -2047 deletions) <details> <summary>View changed files</summary> 📝 `proxmox/config_qemu.go` (+8 -2) 📝 `proxmox/config_qemu_test.go` (+2104 -2045) </details> ### 📄 Description Noticed that #255 broke `ConfigQemu`. `Node`, `Pool`, `VmID` Work Done: - Fixed bug a752d2201e949d272f94a2a1b5ddf81122330223 - Added unit test 761523a724cda6c3e7aa31f658498799071258d9 - Changed structure of existing unit test to allow for easier extension f5eb43dfade238b7836d26096ee2d6ce88d6e57d. The change was nesting all existing Disk tests into an array item so each top level parameter in `ConfigQemu` has it's own array entry. This way the item containing the Disk tasks can be collapsed making the test more readable. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>