[PR #270] [MERGED] Feature: QemuDisk-WWN #356

New issue

Closed

opened 2026-02-28 00:41:53 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 00:41:53 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Telmate/proxmox-api-go/pull/270
Author: @Tinyblargon
Created: 6/21/2023
Status: ✅ Merged
Merged: 12/6/2023
Merged by: @mleone87

Base: master ← Head: Feature-Qemu_Disk-wwn

📝 Commits (4)

c3bd7b7 test: added for api wwn setting
eb08997 feat: add logic for converting wwn
0c3dcc2 test: added for QemuWorldWideName
32d9a2d feat: validator QemuWorldWideName

📊 Changes

8 files changed (+917 additions, -545 deletions)

View changed files

📝 proxmox/config_qemu_disk.go (+25 -3)
📝 proxmox/config_qemu_disk_ide.go (+77 -71)
📝 proxmox/config_qemu_disk_sata.go (+77 -71)
📝 proxmox/config_qemu_disk_scsi.go (+89 -83)
📝 proxmox/config_qemu_disk_test.go (+22 -0)
📝 proxmox/config_qemu_disk_virtio.go (+83 -77)
📝 proxmox/config_qemu_test.go (+432 -240)
➕ test/data/test_data_qemu/type_QemuWorldWideName.go (+112 -0)

📄 Description

Work done this PR

Added wwn property.
Added validate function to check if a wwn is valid.
Added unit tests.

Due to spacing changes in structs and test cases needed for a regex the change looks much bigger than it actually is.

Added this feature so https://github.com/Telmate/terraform-provider-proxmox/pull/794 won't drop support for wwn option.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Telmate/proxmox-api-go/pull/270 **Author:** [@Tinyblargon](https://github.com/Tinyblargon) **Created:** 6/21/2023 **Status:** ✅ Merged **Merged:** 12/6/2023 **Merged by:** [@mleone87](https://github.com/mleone87) **Base:** `master` ← **Head:** `Feature-Qemu_Disk-wwn` --- ### 📝 Commits (4) - [`c3bd7b7`](https://github.com/Telmate/proxmox-api-go/commit/c3bd7b7b2747f7877aa3045fb30f3c18d1a1f3d5) test: added for api `wwn` setting - [`eb08997`](https://github.com/Telmate/proxmox-api-go/commit/eb08997b596a8a192ced85f51d66e7930ffeb82c) feat: add logic for converting `wwn` - [`0c3dcc2`](https://github.com/Telmate/proxmox-api-go/commit/0c3dcc2958491e8e5022e6020fc9c43cde672db2) test: added for `QemuWorldWideName` - [`32d9a2d`](https://github.com/Telmate/proxmox-api-go/commit/32d9a2dcbed4a5720e35eba0e051061d0ed66948) feat: validator `QemuWorldWideName` ### 📊 Changes **8 files changed** (+917 additions, -545 deletions) <details> <summary>View changed files</summary> 📝 `proxmox/config_qemu_disk.go` (+25 -3) 📝 `proxmox/config_qemu_disk_ide.go` (+77 -71) 📝 `proxmox/config_qemu_disk_sata.go` (+77 -71) 📝 `proxmox/config_qemu_disk_scsi.go` (+89 -83) 📝 `proxmox/config_qemu_disk_test.go` (+22 -0) 📝 `proxmox/config_qemu_disk_virtio.go` (+83 -77) 📝 `proxmox/config_qemu_test.go` (+432 -240) ➕ `test/data/test_data_qemu/type_QemuWorldWideName.go` (+112 -0) </details> ### 📄 Description Work done this PR - Added wwn property. - Added validate function to check if a wwn is valid. - Added unit tests. Due to spacing changes in structs and test cases needed for a regex the change looks much bigger than it actually is. Added this feature so https://github.com/Telmate/terraform-provider-proxmox/pull/794 won't drop support for wwn option. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>