[GH-ISSUE #171] Feature Reqest: New Cli #34

Open
opened 2026-02-28 00:40:16 +03:00 by kerem · 2 comments
Owner

Originally created by @Tinyblargon on GitHub (Apr 27, 2022).
Original GitHub issue: https://github.com/Telmate/proxmox-api-go/issues/171

In Tinyblargon/proxmox-api-go:CLI-Overhaul I have started working on a new CLI for the project using cobra. this library is commonly used to create a CLI in GO. it has build in features like "--help" making the project more accessible for new users.
The goal is to eventually replace the big switch statement in main with this new CLI.
The new CLI has to be enabled manually, this can be done by setting the environment variable "NEW_CLI" to "true".

Is this CLI rewrite usefull for the project?
If so should it be merged as one big pull request once the whole CLI is rewritten? Or create pull requests as i go?

Originally created by @Tinyblargon on GitHub (Apr 27, 2022). Original GitHub issue: https://github.com/Telmate/proxmox-api-go/issues/171 In [Tinyblargon/proxmox-api-go:CLI-Overhaul](https://github.com/Tinyblargon/proxmox-api-go/tree/CLI-Overhaul) I have started working on a new CLI for the project using [cobra](https://github.com/spf13/cobra). this library is commonly used to create a CLI in GO. it has build in features like "--help" making the project more accessible for new users. The goal is to eventually replace the big switch statement in main with this new CLI. The new CLI has to be enabled manually, this can be done by setting the environment variable "NEW_CLI" to "true". Is this CLI rewrite usefull for the project? If so should it be merged as one big pull request once the whole CLI is rewritten? Or create pull requests as i go?
Author
Owner

@mleone87 commented on GitHub (Apr 28, 2022):

Is this CLI rewrite usefull for the project?

for sure! I think that this could be the v1.0.0 release of this project?

If so should it be merged as one big pull request once the whole CLI is rewritten? Or create pull requests as i go?

merging in a new branch could be an option too? When finished we can merge it into main

<!-- gh-comment-id:1111970232 --> @mleone87 commented on GitHub (Apr 28, 2022): > Is this CLI rewrite usefull for the project? for sure! I think that this could be the v1.0.0 release of this project? > If so should it be merged as one big pull request once the whole CLI is rewritten? Or create pull requests as i go? merging in a new branch could be an option too? When finished we can merge it into main
Author
Owner

@ggongaware commented on GitHub (Apr 28, 2022):

Cobra looks like a good replacement to manage the CLI. It should give the opportunity for more test coverage which would help validate a release process.

<!-- gh-comment-id:1112254242 --> @ggongaware commented on GitHub (Apr 28, 2022): Cobra looks like a good replacement to manage the CLI. It should give the opportunity for more test coverage which would help validate a release process.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/proxmox-api-go#34
No description provided.