[PR #229] [MERGED] Small Refactoring #325

New issue

Closed

opened 2026-02-28 00:41:45 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 00:41:45 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Telmate/proxmox-api-go/pull/229
Author: @Tinyblargon
Created: 1/12/2023
Status: ✅ Merged
Merged: 1/12/2023
Merged by: @mleone87

Base: master ← Head: Refactoring

📝 Commits (4)

b0391f3 refactor: change function name
06f42f8 refactor: make names CamelCase
7063c93 refactor: fix typos
4520a27 refactor: fix typos

📊 Changes

8 files changed (+106 additions, -83 deletions)

View changed files

📝 proxmox/client.go (+2 -2)
📝 proxmox/config_acme_account.go (+2 -2)
📝 proxmox/config_acme_plugin.go (+6 -6)
📝 proxmox/config_lxc.go (+3 -3)
📝 proxmox/config_metrics.go (+73 -49)
📝 proxmox/config_network.go (+5 -6)
📝 proxmox/config_storage.go (+13 -13)
📝 proxmox/snapshot.go (+2 -2)

📄 Description

Work done this pull.

Changed the name of the functions responsible for mapping values to the Proxmox API to mapToApiValues(). This should make the code more readable and homogeneous.
Made variable names Camel Case.
Fixed typos.

The major change in proxmox/config_metrics.go is the linter changing the formatting.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Telmate/proxmox-api-go/pull/229 **Author:** [@Tinyblargon](https://github.com/Tinyblargon) **Created:** 1/12/2023 **Status:** ✅ Merged **Merged:** 1/12/2023 **Merged by:** [@mleone87](https://github.com/mleone87) **Base:** `master` ← **Head:** `Refactoring` --- ### 📝 Commits (4) - [`b0391f3`](https://github.com/Telmate/proxmox-api-go/commit/b0391f3ef97ca9fa8c9759d2f769d9d85117a982) refactor: change function name - [`06f42f8`](https://github.com/Telmate/proxmox-api-go/commit/06f42f8776afd6208d50a45cd4201736ee70ea54) refactor: make names CamelCase - [`7063c93`](https://github.com/Telmate/proxmox-api-go/commit/7063c937ed92112398e829c53480f76fec9ded4a) refactor: fix typos - [`4520a27`](https://github.com/Telmate/proxmox-api-go/commit/4520a27aaff38ed1fd02d7fde0e6f1159b802701) refactor: fix typos ### 📊 Changes **8 files changed** (+106 additions, -83 deletions) <details> <summary>View changed files</summary> 📝 `proxmox/client.go` (+2 -2) 📝 `proxmox/config_acme_account.go` (+2 -2) 📝 `proxmox/config_acme_plugin.go` (+6 -6) 📝 `proxmox/config_lxc.go` (+3 -3) 📝 `proxmox/config_metrics.go` (+73 -49) 📝 `proxmox/config_network.go` (+5 -6) 📝 `proxmox/config_storage.go` (+13 -13) 📝 `proxmox/snapshot.go` (+2 -2) </details> ### 📄 Description Work done this pull. - Changed the name of the functions responsible for mapping values to the Proxmox API to `mapToApiValues()`. This should make the code more readable and homogeneous. - Made variable names Camel Case. - Fixed typos. The major change in `proxmox/config_metrics.go` is the linter changing the formatting. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>