[PR #222] [MERGED] Update Github Workflow #320

Closed
opened 2026-02-28 00:41:44 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/Telmate/proxmox-api-go/pull/222
Author: @Tinyblargon
Created: 12/9/2022
Status: Merged
Merged: 12/9/2022
Merged by: @mleone87

Base: masterHead: workflow


📝 Commits (2)

  • 904be2a build: run all tests in the ./proxmox directory
  • 511660c test: Remove Login test

📊 Changes

2 files changed (+2 additions, -19 deletions)

View changed files

📝 .github/workflows/go.yml (+2 -2)
proxmox/client_test.go (+0 -17)

📄 Description

Updated the Github workflow to allow for some automated testing.

Work done:

  • Made the Github workflow only run the test in ./proxmox as all these tests should be unit tests and shouldn't require any external dependencies.
  • Removed the Login test in ./proxmox as it requires a PVE system to be tested. this test case is also extensively covered by the integration tests in /test/cli.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Telmate/proxmox-api-go/pull/222 **Author:** [@Tinyblargon](https://github.com/Tinyblargon) **Created:** 12/9/2022 **Status:** ✅ Merged **Merged:** 12/9/2022 **Merged by:** [@mleone87](https://github.com/mleone87) **Base:** `master` ← **Head:** `workflow` --- ### 📝 Commits (2) - [`904be2a`](https://github.com/Telmate/proxmox-api-go/commit/904be2ae6f97e375a0788aa6011d82c8ac07be80) build: run all tests in the ./proxmox directory - [`511660c`](https://github.com/Telmate/proxmox-api-go/commit/511660c7bec07f11d84d8eda75d8f466d109d50c) test: Remove Login test ### 📊 Changes **2 files changed** (+2 additions, -19 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/go.yml` (+2 -2) ➖ `proxmox/client_test.go` (+0 -17) </details> ### 📄 Description Updated the Github workflow to allow for some automated testing. Work done: - Made the Github workflow only run the test in ./proxmox as all these tests should be unit tests and shouldn't require any external dependencies. - Removed the Login test in ./proxmox as it requires a PVE system to be tested. this test case is also extensively covered by the integration tests in /test/cli. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-28 00:41:44 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/proxmox-api-go#320
No description provided.