[PR #213] [MERGED] Fixed Typo's and small refactoring #314

New issue

Closed

opened 2026-02-28 00:41:43 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 00:41:43 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Telmate/proxmox-api-go/pull/213
Author: @Tinyblargon
Created: 10/31/2022
Status: ✅ Merged
Merged: 11/1/2022
Merged by: @mleone87

Base: master ← Head: master

📝 Commits (9)

e842a1b refactor: Change function names and add comments
d4878a3 refactor: Move Snapshot CRUD actions out of *client class
4165820 feat: Set number of arguments on commands
212ca59 fix: Typo's in the new cli
f3aca95 fix: Give reboot command correct message
881643f fix: add STORAGEID to command usage
e3e4976 refactor: Make variables CamelCase
24ee8d4 fix: Typo in comment and command description
23b2609 fix: Typo's in comments and error messages

📊 Changes

56 files changed (+184 additions, -136 deletions)

View changed files

📝 cli/cobra.go (+4 -4)
📝 cli/command/create/create-acmeaccount.go (+1 -0)
📝 cli/command/create/create-pool.go (+1 -0)
📝 cli/command/create/create-snapshot.go (+2 -2)
📝 cli/command/create/create-storage.go (+1 -0)
📝 cli/command/create/guest/create-guest-lxc.go (+1 -0)
📝 cli/command/create/guest/create-guest-qemu.go (+1 -0)
📝 cli/command/delete/delete-acmeaccount.go (+2 -1)
📝 cli/command/delete/delete-guest.go (+2 -1)
📝 cli/command/delete/delete-metricserver.go (+2 -1)
📝 cli/command/delete/delete-pool.go (+2 -1)
📝 cli/command/delete/delete-snapshot.go (+2 -3)
📝 cli/command/delete/delete-storage.go (+2 -1)
📝 cli/command/delete/delete-user.go (+2 -1)
📝 cli/command/get/get-acmeaccount.go (+1 -0)
📝 cli/command/get/get-guest.go (+1 -0)
📝 cli/command/get/get-metricserver.go (+1 -0)
📝 cli/command/get/get-pool.go (+1 -0)
📝 cli/command/get/get-storage.go (+2 -1)
📝 cli/command/get/get-user.go (+1 -0)

...and 36 more files

📄 Description

Fixed lots of typos in comments, error messages and the description of CLI commands.
Specified the number of arguments for each CLI command.
Moved the snapshot function out of the *Client class.
Renamed the CreateItem, UpdateItem and DeleteItem in the *Client class to Post, Put and Delete. also improved the description of these commands.
Refactored some internal variables to be CamelCase.
Checked i didn't rename anything used by the Terraform provider.
Ran CLI integration test, they all where successful.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Telmate/proxmox-api-go/pull/213 **Author:** [@Tinyblargon](https://github.com/Tinyblargon) **Created:** 10/31/2022 **Status:** ✅ Merged **Merged:** 11/1/2022 **Merged by:** [@mleone87](https://github.com/mleone87) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (9) - [`e842a1b`](https://github.com/Telmate/proxmox-api-go/commit/e842a1b2e4ea02e47731bf3d4a2dc9f332688014) refactor: Change function names and add comments - [`d4878a3`](https://github.com/Telmate/proxmox-api-go/commit/d4878a322b6eab9347857d5f20d3e3d83eaff48a) refactor: Move Snapshot CRUD actions out of *client class - [`4165820`](https://github.com/Telmate/proxmox-api-go/commit/4165820b2de3775e6917c04811f05b5803f25332) feat: Set number of arguments on commands - [`212ca59`](https://github.com/Telmate/proxmox-api-go/commit/212ca595128ab3120e62673c3d84b432b0a889ea) fix: Typo's in the new cli - [`f3aca95`](https://github.com/Telmate/proxmox-api-go/commit/f3aca95532ca5b04363462e96e698759fd0cee4f) fix: Give reboot command correct message - [`881643f`](https://github.com/Telmate/proxmox-api-go/commit/881643fa2ba507a38e51682edde52100389f7d51) fix: add STORAGEID to command usage - [`e3e4976`](https://github.com/Telmate/proxmox-api-go/commit/e3e4976d9c34cdd1ba02db6e780b0afdcfe8374f) refactor: Make variables CamelCase - [`24ee8d4`](https://github.com/Telmate/proxmox-api-go/commit/24ee8d468407cdb33a70747ed2293020526aad63) fix: Typo in comment and command description - [`23b2609`](https://github.com/Telmate/proxmox-api-go/commit/23b26094ae8a4dd59d19a48f213778291d1b41ad) fix: Typo's in comments and error messages ### 📊 Changes **56 files changed** (+184 additions, -136 deletions) <details> <summary>View changed files</summary> 📝 `cli/cobra.go` (+4 -4) 📝 `cli/command/create/create-acmeaccount.go` (+1 -0) 📝 `cli/command/create/create-pool.go` (+1 -0) 📝 `cli/command/create/create-snapshot.go` (+2 -2) 📝 `cli/command/create/create-storage.go` (+1 -0) 📝 `cli/command/create/guest/create-guest-lxc.go` (+1 -0) 📝 `cli/command/create/guest/create-guest-qemu.go` (+1 -0) 📝 `cli/command/delete/delete-acmeaccount.go` (+2 -1) 📝 `cli/command/delete/delete-guest.go` (+2 -1) 📝 `cli/command/delete/delete-metricserver.go` (+2 -1) 📝 `cli/command/delete/delete-pool.go` (+2 -1) 📝 `cli/command/delete/delete-snapshot.go` (+2 -3) 📝 `cli/command/delete/delete-storage.go` (+2 -1) 📝 `cli/command/delete/delete-user.go` (+2 -1) 📝 `cli/command/get/get-acmeaccount.go` (+1 -0) 📝 `cli/command/get/get-guest.go` (+1 -0) 📝 `cli/command/get/get-metricserver.go` (+1 -0) 📝 `cli/command/get/get-pool.go` (+1 -0) 📝 `cli/command/get/get-storage.go` (+2 -1) 📝 `cli/command/get/get-user.go` (+1 -0) _...and 36 more files_ </details> ### 📄 Description - Fixed lots of typos in comments, error messages and the description of CLI commands. - Specified the number of arguments for each CLI command. - Moved the snapshot function out of the `*Client` class. - Renamed the `CreateItem`, `UpdateItem` and `DeleteItem` in the `*Client` class to `Post`, `Put` and `Delete`. also improved the description of these commands. - Refactored some internal variables to be CamelCase. - Checked i didn't rename anything used by the Terraform provider. - Ran CLI integration test, they all where successful. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>