[PR #190] [MERGED] Cli overhaul: user password change #297

New issue

Closed

opened 2026-02-28 00:41:40 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 00:41:40 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Telmate/proxmox-api-go/pull/190
Author: @Tinyblargon
Created: 9/2/2022
Status: ✅ Merged
Merged: 9/3/2022
Merged by: @mleone87

Base: master ← Head: CLI-Overhaul

📝 Commits (2)

09bf103 user password change option and refactoring
a8e3d64 test for updating user password and refactoring

📊 Changes

3 files changed (+114 additions, -59 deletions)

View changed files

📝 proxmox/config_user.go (+58 -24)
📝 test/cli/Users/User_0_test.go (+36 -16)
📝 test/cli/Users/User_1_test.go (+20 -19)

📄 Description

Another pull for https://github.com/Telmate/proxmox-api-go/issues/171

Work so far:

Made the config for the set user command optional, so this command can be used to change a users password.
Created integration tests for user password change function.
Made a change to the tests as Proxmox had a bug where it would ignore the value of the "expire" parameter. Which meant that the user would be disabled during the tests.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Telmate/proxmox-api-go/pull/190 **Author:** [@Tinyblargon](https://github.com/Tinyblargon) **Created:** 9/2/2022 **Status:** ✅ Merged **Merged:** 9/3/2022 **Merged by:** [@mleone87](https://github.com/mleone87) **Base:** `master` ← **Head:** `CLI-Overhaul` --- ### 📝 Commits (2) - [`09bf103`](https://github.com/Telmate/proxmox-api-go/commit/09bf103acaa0cbfee0e0a1a57c4cebc784f59e70) user password change option and refactoring - [`a8e3d64`](https://github.com/Telmate/proxmox-api-go/commit/a8e3d64c0cf7ce53e90a8ecb07a450f4ef53f626) test for updating user password and refactoring ### 📊 Changes **3 files changed** (+114 additions, -59 deletions) <details> <summary>View changed files</summary> 📝 `proxmox/config_user.go` (+58 -24) 📝 `test/cli/Users/User_0_test.go` (+36 -16) 📝 `test/cli/Users/User_1_test.go` (+20 -19) </details> ### 📄 Description Another pull for https://github.com/Telmate/proxmox-api-go/issues/171 Work so far: - Made the config for the set user command optional, so this command can be used to change a users password. - Created integration tests for user password change function. - Made a change to the tests as Proxmox had a bug where it would ignore the value of the "expire" parameter. Which meant that the user would be disabled during the tests. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>