[PR #188] [MERGED] Cli overhaul: acmeaccount #295

New issue

Closed

opened 2026-02-28 00:41:39 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 00:41:39 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Telmate/proxmox-api-go/pull/188
Author: @Tinyblargon
Created: 8/19/2022
Status: ✅ Merged
Merged: 8/31/2022
Merged by: @mleone87

Base: master ← Head: CLI-Overhaul

📝 Commits (4)

fc390ab Add: acmeaccount commands
31fd660 Update: usage description
5fee9d8 Tests for acmeaccount
56181cf Return err when error occures

📊 Changes

8 files changed (+216 additions, -15 deletions)

View changed files

➕ cli/command/create/create-acmeaccount.go (+33 -0)
➕ cli/command/delete/delete-acmeaccount.go (+17 -0)
📝 cli/command/delete/delete.go (+14 -6)
➕ cli/command/get/get-acmeaccount.go (+17 -0)
📝 cli/command/get/get.go (+7 -5)
📝 proxmox/client.go (+4 -4)
➕ test/cli/AcmeAccount/AcmeAccount_0_test.go (+65 -0)
➕ test/cli/AcmeAccount/AcmeAccount_1_test.go (+59 -0)

📄 Description

Another pull for https://github.com/Telmate/proxmox-api-go/issues/171

Work so far:

Created all the commands for the acmeaccount function.
Created integration tests for acmeaccount function.

Patched an issue where the error would always be returned as nil, instead of returning the actual value error.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Telmate/proxmox-api-go/pull/188 **Author:** [@Tinyblargon](https://github.com/Tinyblargon) **Created:** 8/19/2022 **Status:** ✅ Merged **Merged:** 8/31/2022 **Merged by:** [@mleone87](https://github.com/mleone87) **Base:** `master` ← **Head:** `CLI-Overhaul` --- ### 📝 Commits (4) - [`fc390ab`](https://github.com/Telmate/proxmox-api-go/commit/fc390abb4e4edff592e88d953ba3ab5f79a0e78d) Add: acmeaccount commands - [`31fd660`](https://github.com/Telmate/proxmox-api-go/commit/31fd660fb2b71b60eee2bb626c74dc319cceae95) Update: usage description - [`5fee9d8`](https://github.com/Telmate/proxmox-api-go/commit/5fee9d857eb828f453a4f5f543c6cb3ea9732d9e) Tests for acmeaccount - [`56181cf`](https://github.com/Telmate/proxmox-api-go/commit/56181cf0ec4dcf148ed65c0786738c4719c02c7f) Return err when error occures ### 📊 Changes **8 files changed** (+216 additions, -15 deletions) <details> <summary>View changed files</summary> ➕ `cli/command/create/create-acmeaccount.go` (+33 -0) ➕ `cli/command/delete/delete-acmeaccount.go` (+17 -0) 📝 `cli/command/delete/delete.go` (+14 -6) ➕ `cli/command/get/get-acmeaccount.go` (+17 -0) 📝 `cli/command/get/get.go` (+7 -5) 📝 `proxmox/client.go` (+4 -4) ➕ `test/cli/AcmeAccount/AcmeAccount_0_test.go` (+65 -0) ➕ `test/cli/AcmeAccount/AcmeAccount_1_test.go` (+59 -0) </details> ### 📄 Description Another pull for https://github.com/Telmate/proxmox-api-go/issues/171 Work so far: - Created all the commands for the acmeaccount function. - Created integration tests for acmeaccount function. Patched an issue where the error would always be returned as nil, instead of returning the actual value error. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>