[PR #186] [MERGED] Cli overhaul: storage #294

New issue

Closed

opened 2026-02-28 00:41:38 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 00:41:38 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Telmate/proxmox-api-go/pull/186
Author: @Tinyblargon
Created: 8/10/2022
Status: ✅ Merged
Merged: 8/18/2022
Merged by: @mleone87

Base: master ← Head: CLI-Overhaul

📝 Commits (6)

f615923 Add: storage command and bug fixes
797ff24 Add: storage intergration tests
38ec8d4 Merge branch 'Telmate:master' into CLI-Overhaul
44bc3de Add: namespace to PBS
4fc8a31 Consolidate test code
e9b47a2 Consolidate more test code

📊 Changes

55 files changed (+2448 additions, -279 deletions)

View changed files

➕ cli/command/create/create-storage.go (+33 -0)
➕ cli/command/delete/delete-storage.go (+17 -0)
📝 cli/command/delete/delete.go (+2 -0)
➕ cli/command/get/get-storage.go (+17 -0)
📝 cli/command/get/get.go (+2 -0)
➕ cli/command/update/update-storage.go (+33 -0)
📝 proxmox/config_storage.go (+345 -263)
📝 proxmox/validate.go (+17 -16)
➕ test/cli/Storage/Storage_CephFS_0_test.go (+36 -0)
➕ test/cli/Storage/Storage_CephFS_1_test.go (+36 -0)
➕ test/cli/Storage/Storage_Directory_0_test.go (+36 -0)
➕ test/cli/Storage/Storage_Directory_1_test.go (+36 -0)
➕ test/cli/Storage/Storage_GlusterFS_0_test.go (+36 -0)
➕ test/cli/Storage/Storage_GlusterFS_1_test.go (+36 -0)
➕ test/cli/Storage/Storage_ISCSI_0_test.go (+36 -0)
➕ test/cli/Storage/Storage_ISCSI_1_test.go (+36 -0)
➕ test/cli/Storage/Storage_LVM-Thin_0_test.go (+34 -0)
➕ test/cli/Storage/Storage_LVM-Thin_1_test.go (+34 -0)
➕ test/cli/Storage/Storage_LVM_0_test.go (+36 -0)
➕ test/cli/Storage/Storage_LVM_1_test.go (+36 -0)

...and 35 more files

📄 Description

Another pull for https://github.com/Telmate/proxmox-api-go/issues/171

Work so far:

Created all the commands for the storage function.
Created integration tests for storage function.

Made minor changes to how the storage feature works, as it had some unintended behavior and bugs.

The test are by no means covering every possible case but are the bare minimum needed to have some confidence in the code.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Telmate/proxmox-api-go/pull/186 **Author:** [@Tinyblargon](https://github.com/Tinyblargon) **Created:** 8/10/2022 **Status:** ✅ Merged **Merged:** 8/18/2022 **Merged by:** [@mleone87](https://github.com/mleone87) **Base:** `master` ← **Head:** `CLI-Overhaul` --- ### 📝 Commits (6) - [`f615923`](https://github.com/Telmate/proxmox-api-go/commit/f6159235e2a81925ba0c2ba3c4bfefb19eed4dc3) Add: storage command and bug fixes - [`797ff24`](https://github.com/Telmate/proxmox-api-go/commit/797ff248d30c4eeeb03c1a818cb10a83ede4018d) Add: storage intergration tests - [`38ec8d4`](https://github.com/Telmate/proxmox-api-go/commit/38ec8d46039d44c09dec06ec49f1ddb90db43050) Merge branch 'Telmate:master' into CLI-Overhaul - [`44bc3de`](https://github.com/Telmate/proxmox-api-go/commit/44bc3de65eb53aaaba3c8fc5dcba528305920a7f) Add: namespace to PBS - [`4fc8a31`](https://github.com/Telmate/proxmox-api-go/commit/4fc8a31331e11d51ee78583ecffa699b230ce1f3) Consolidate test code - [`e9b47a2`](https://github.com/Telmate/proxmox-api-go/commit/e9b47a2b1b6e5a4738c52ae72aa66ef3feb106c1) Consolidate more test code ### 📊 Changes **55 files changed** (+2448 additions, -279 deletions) <details> <summary>View changed files</summary> ➕ `cli/command/create/create-storage.go` (+33 -0) ➕ `cli/command/delete/delete-storage.go` (+17 -0) 📝 `cli/command/delete/delete.go` (+2 -0) ➕ `cli/command/get/get-storage.go` (+17 -0) 📝 `cli/command/get/get.go` (+2 -0) ➕ `cli/command/update/update-storage.go` (+33 -0) 📝 `proxmox/config_storage.go` (+345 -263) 📝 `proxmox/validate.go` (+17 -16) ➕ `test/cli/Storage/Storage_CephFS_0_test.go` (+36 -0) ➕ `test/cli/Storage/Storage_CephFS_1_test.go` (+36 -0) ➕ `test/cli/Storage/Storage_Directory_0_test.go` (+36 -0) ➕ `test/cli/Storage/Storage_Directory_1_test.go` (+36 -0) ➕ `test/cli/Storage/Storage_GlusterFS_0_test.go` (+36 -0) ➕ `test/cli/Storage/Storage_GlusterFS_1_test.go` (+36 -0) ➕ `test/cli/Storage/Storage_ISCSI_0_test.go` (+36 -0) ➕ `test/cli/Storage/Storage_ISCSI_1_test.go` (+36 -0) ➕ `test/cli/Storage/Storage_LVM-Thin_0_test.go` (+34 -0) ➕ `test/cli/Storage/Storage_LVM-Thin_1_test.go` (+34 -0) ➕ `test/cli/Storage/Storage_LVM_0_test.go` (+36 -0) ➕ `test/cli/Storage/Storage_LVM_1_test.go` (+36 -0) _...and 35 more files_ </details> ### 📄 Description Another pull for https://github.com/Telmate/proxmox-api-go/issues/171 Work so far: Created all the commands for the storage function. Created integration tests for storage function. Made minor changes to how the storage feature works, as it had some unintended behavior and bugs. The test are by no means covering every possible case but are the bare minimum needed to have some confidence in the code. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>