[PR #177] [MERGED] Cli overhaul #287

New issue

Closed

opened 2026-02-28 00:41:37 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 00:41:37 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Telmate/proxmox-api-go/pull/177
Author: @Tinyblargon
Created: 5/9/2022
Status: ✅ Merged
Merged: 5/9/2022
Merged by: @mleone87

Base: master ← Head: CLI-Overhaul

📝 Commits (10+)

8d8762b Beginning of a new cli using cobra
98fe1c4 Copy NewClient logic from main to cobra
d1b6f22 Added List commands
8167c02 New inplementation of the list snapshots feature
5206832 Add Intergration test for List_Nodes, List_Users
3869e5b Change Error handeling
8077a0f Add Pool Create,Delete,Get,update Functions
804252b Intergration Test: Pool
ed8e754 Merge branch 'Telmate:master' into CLI-Overhaul
8797572 Add Set user command

📊 Changes

39 files changed (+1272 additions, -3 deletions)

View changed files

➕ cli/cobra.go (+94 -0)
➕ cli/command/commands/commands.go (+11 -0)
➕ cli/command/create/create-pool.go (+29 -0)
➕ cli/command/create/create.go (+15 -0)
➕ cli/command/delete/delete-metricserver.go (+17 -0)
➕ cli/command/delete/delete-pool.go (+18 -0)
➕ cli/command/delete/delete-user.go (+18 -0)
➕ cli/command/delete/delete.go (+33 -0)
➕ cli/command/example/example.go (+15 -0)
➕ cli/command/get/get-pool.go (+31 -0)
➕ cli/command/get/get-user.go (+17 -0)
➕ cli/command/get/get.go (+31 -0)
➕ cli/command/list/list-acmeaccounts.go (+18 -0)
➕ cli/command/list/list-acmeplugins.go (+18 -0)
➕ cli/command/list/list-guests.go (+17 -0)
➕ cli/command/list/list-metricservers.go (+18 -0)
➕ cli/command/list/list-nodes.go (+17 -0)
➕ cli/command/list/list-pools.go (+18 -0)
➕ cli/command/list/list-snapshots.go (+37 -0)
➕ cli/command/list/list-storages.go (+18 -0)

...and 19 more files

📄 Description

This is one of many pull request for feature #171

Work so far:

Created all the commands for the pool and user function.
Created the integration tests for the user and pool function.

for the user tests to be covering all cases we would first need to be able to create and delete groups, i will start working on this feature shortly.

the new CLI will only be used when the environment variable "NEW_CLI"="true"

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Telmate/proxmox-api-go/pull/177 **Author:** [@Tinyblargon](https://github.com/Tinyblargon) **Created:** 5/9/2022 **Status:** ✅ Merged **Merged:** 5/9/2022 **Merged by:** [@mleone87](https://github.com/mleone87) **Base:** `master` ← **Head:** `CLI-Overhaul` --- ### 📝 Commits (10+) - [`8d8762b`](https://github.com/Telmate/proxmox-api-go/commit/8d8762b5041aa2926270e415090f1890211cbddd) Beginning of a new cli using cobra - [`98fe1c4`](https://github.com/Telmate/proxmox-api-go/commit/98fe1c4acd88d045863b3a91f931481fd2a31e3c) Copy NewClient logic from main to cobra - [`d1b6f22`](https://github.com/Telmate/proxmox-api-go/commit/d1b6f22bbe376296410bb700010ae3b20a945288) Added List commands - [`8167c02`](https://github.com/Telmate/proxmox-api-go/commit/8167c029c9ca880ae1d108e47affd6cf211ced65) New inplementation of the list snapshots feature - [`5206832`](https://github.com/Telmate/proxmox-api-go/commit/5206832553c6471a4d2da5c87d4900ebdbd3d40c) Add Intergration test for List_Nodes, List_Users - [`3869e5b`](https://github.com/Telmate/proxmox-api-go/commit/3869e5b2d84c92b8155ac32ea2281a9930b94043) Change Error handeling - [`8077a0f`](https://github.com/Telmate/proxmox-api-go/commit/8077a0fd95e58a09f908e78a8f6e37ee4b3b98c6) Add Pool Create,Delete,Get,update Functions - [`804252b`](https://github.com/Telmate/proxmox-api-go/commit/804252bf9ebf8ea0b2cc818bdb8b5a3ec609d653) Intergration Test: Pool - [`ed8e754`](https://github.com/Telmate/proxmox-api-go/commit/ed8e7549af5b26742c8e299791ebfcad916a3f9f) Merge branch 'Telmate:master' into CLI-Overhaul - [`8797572`](https://github.com/Telmate/proxmox-api-go/commit/8797572698d39cbfd9bfe0d42d601351de5a6a76) Add Set user command ### 📊 Changes **39 files changed** (+1272 additions, -3 deletions) <details> <summary>View changed files</summary> ➕ `cli/cobra.go` (+94 -0) ➕ `cli/command/commands/commands.go` (+11 -0) ➕ `cli/command/create/create-pool.go` (+29 -0) ➕ `cli/command/create/create.go` (+15 -0) ➕ `cli/command/delete/delete-metricserver.go` (+17 -0) ➕ `cli/command/delete/delete-pool.go` (+18 -0) ➕ `cli/command/delete/delete-user.go` (+18 -0) ➕ `cli/command/delete/delete.go` (+33 -0) ➕ `cli/command/example/example.go` (+15 -0) ➕ `cli/command/get/get-pool.go` (+31 -0) ➕ `cli/command/get/get-user.go` (+17 -0) ➕ `cli/command/get/get.go` (+31 -0) ➕ `cli/command/list/list-acmeaccounts.go` (+18 -0) ➕ `cli/command/list/list-acmeplugins.go` (+18 -0) ➕ `cli/command/list/list-guests.go` (+17 -0) ➕ `cli/command/list/list-metricservers.go` (+18 -0) ➕ `cli/command/list/list-nodes.go` (+17 -0) ➕ `cli/command/list/list-pools.go` (+18 -0) ➕ `cli/command/list/list-snapshots.go` (+37 -0) ➕ `cli/command/list/list-storages.go` (+18 -0) _...and 19 more files_ </details> ### 📄 Description This is one of many pull request for feature #171 Work so far: - Created all the commands for the pool and user function. - Created the integration tests for the user and pool function. for the user tests to be covering all cases we would first need to be able to create and delete groups, i will start working on this feature shortly. the new CLI will only be used when the environment variable "NEW_CLI"="true" --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>