[PR #144] [MERGED] Fix HA Group setup for LXC containers #265

New issue

Closed

opened 2026-02-28 00:41:29 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 00:41:29 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Telmate/proxmox-api-go/pull/144
Author: @RubenHoms
Created: 10/25/2021
Status: ✅ Merged
Merged: 10/25/2021
Merged by: @ggongaware

Base: master ← Head: master

📝 Commits (1)

b779ef3 Fix HA Group setup for LXC containers

📊 Changes

1 file changed (+7 additions, -1 deletions)

View changed files

📝 proxmox/config_lxc.go (+7 -1)

📄 Description

In #142 I wrote the code to support the HA Group parameter only for QEMU resources. However in my pull request upstream here I implemented it both for QEMU and LXC. However as there was no support for this in this library yet, it broke things.

Sorry for being careless. I have not tested this yet as I don't work with LXC containers myself but looking through the Proxmox API and source code these changes should work. Would appreciate if someone could test it to double check though.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Telmate/proxmox-api-go/pull/144 **Author:** [@RubenHoms](https://github.com/RubenHoms) **Created:** 10/25/2021 **Status:** ✅ Merged **Merged:** 10/25/2021 **Merged by:** [@ggongaware](https://github.com/ggongaware) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`b779ef3`](https://github.com/Telmate/proxmox-api-go/commit/b779ef3f649827697e1c861a1a1a9cdb9d4927df) Fix HA Group setup for LXC containers ### 📊 Changes **1 file changed** (+7 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `proxmox/config_lxc.go` (+7 -1) </details> ### 📄 Description In #142 I wrote the code to support the HA Group parameter only for QEMU resources. However in my pull request upstream [here](https://github.com/Telmate/terraform-provider-proxmox/pull/423) I implemented it both for QEMU and LXC. However as there was no support for this in this library yet, it [broke things](https://github.com/Telmate/terraform-provider-proxmox/issues/424). Sorry for being careless. I have not tested this yet as I don't work with LXC containers myself but looking through the Proxmox API and source code these changes should work. Would appreciate if someone could test it to double check though. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>