[PR #145] [MERGED] Support for proxies servers, proper LXC HA management, go-staticcheck code fixes, miscs #262

New issue

Closed

opened 2026-02-28 00:41:28 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 00:41:28 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Telmate/proxmox-api-go/pull/145
Author: @mleone87
Created: 10/27/2021
Status: ✅ Merged
Merged: 11/1/2021
Merged by: @ggongaware

Base: master ← Head: master

📝 Commits (7)

ccd664a update gitignore
66513e6 support for proxies, bugfixes in LXC HA, go-statickcheck fixes
ee5382b proper unuseddisks print
d4df3f2 fix proxystring empty case
8999975 docs small upgrade
cd8e5a6 Revert "docs small upgrade"
048852c proper docs update

📊 Changes

9 files changed (+140 additions, -101 deletions)

View changed files

📝 .gitignore (+1 -0)
📝 README.md (+22 -14)
📝 main.go (+2 -1)
📝 proxmox/client.go (+44 -27)
📝 proxmox/client_test.go (+1 -1)
📝 proxmox/config_lxc.go (+18 -19)
📝 proxmox/config_qemu.go (+16 -18)
📝 proxmox/session.go (+32 -14)
📝 proxmox/util.go (+4 -7)

📄 Description

Hi,

here we go with some upgrades on the proxmox api

I've added the support for proxies for easy debugging, just use your preferred proxy (i use mitmproxy) and se what actually happens in term of api calls to/from your lovely proxmox instance cluster
I think I've managed to solve the HA management on LXC side
I changed how unused disks are handled(since we can only read them)
I've cleaned a bit the code following go-staticcheck(not 100%)
Some other small fixes that you can see reading through the diff

Since this is a breaking change for the proxmox provider because the NewClient() function changes it's signature, as soon the PR get merged I'll open a new PR to the provider to support the new api version

thanks

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Telmate/proxmox-api-go/pull/145 **Author:** [@mleone87](https://github.com/mleone87) **Created:** 10/27/2021 **Status:** ✅ Merged **Merged:** 11/1/2021 **Merged by:** [@ggongaware](https://github.com/ggongaware) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (7) - [`ccd664a`](https://github.com/Telmate/proxmox-api-go/commit/ccd664a29a08d8040ccf94e6ad91f218c35efab3) update gitignore - [`66513e6`](https://github.com/Telmate/proxmox-api-go/commit/66513e66a635a3f16d388c7181cd7012febe7293) support for proxies, bugfixes in LXC HA, go-statickcheck fixes - [`ee5382b`](https://github.com/Telmate/proxmox-api-go/commit/ee5382bf7e6f9bfa44b8682d429d7f83700b186d) proper unuseddisks print - [`d4df3f2`](https://github.com/Telmate/proxmox-api-go/commit/d4df3f2fb937fad1715f458e9a764ef0e481a8f1) fix proxystring empty case - [`8999975`](https://github.com/Telmate/proxmox-api-go/commit/899997582b99c1691eeb937fde50e3b2fbbd3cdf) docs small upgrade - [`cd8e5a6`](https://github.com/Telmate/proxmox-api-go/commit/cd8e5a6dae96593edff318d6774195cc74ce9599) Revert "docs small upgrade" - [`048852c`](https://github.com/Telmate/proxmox-api-go/commit/048852ce40eeff1e70ba879f69ee83d9b5c55fcd) proper docs update ### 📊 Changes **9 files changed** (+140 additions, -101 deletions) <details> <summary>View changed files</summary> 📝 `.gitignore` (+1 -0) 📝 `README.md` (+22 -14) 📝 `main.go` (+2 -1) 📝 `proxmox/client.go` (+44 -27) 📝 `proxmox/client_test.go` (+1 -1) 📝 `proxmox/config_lxc.go` (+18 -19) 📝 `proxmox/config_qemu.go` (+16 -18) 📝 `proxmox/session.go` (+32 -14) 📝 `proxmox/util.go` (+4 -7) </details> ### 📄 Description Hi, here we go with some upgrades on the proxmox api - I've added the support for proxies for easy debugging, just use your preferred proxy (i use mitmproxy) and se what actually happens in term of api calls to/from your lovely proxmox instance cluster - I think I've managed to solve the HA management on LXC side - I changed how unused disks are handled(since we can only read them) - I've cleaned a bit the code following go-staticcheck(not 100%) - Some other small fixes that you can see reading through the diff **Since this is a breaking change for the proxmox provider because the NewClient() function changes it's signature, as soon the PR get merged I'll open a new PR to the provider to support the new api version** thanks --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>