[PR #137] [MERGED] Allow explicit empty parameters in request parameters #257

New issue

Closed

opened 2026-02-28 00:41:27 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 00:41:27 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Telmate/proxmox-api-go/pull/137
Author: @wynro
Created: 8/25/2021
Status: ✅ Merged
Merged: 8/25/2021
Merged by: @ggongaware

Base: master ← Head: master

📝 Commits (1)

1360747 Allow explicit empty parameters in request parameters

📊 Changes

3 files changed (+104 additions, -3 deletions)

View changed files

📝 proxmox/client.go (+1 -1)
📝 proxmox/session.go (+13 -2)
➕ proxmox/session_test.go (+90 -0)

📄 Description

Sometimes, it may be useful to allow for empty parameters in the requests.

The example that I'm finding is to allow removing the comment from a pool, but I'm sure it will be useful in other places.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Telmate/proxmox-api-go/pull/137 **Author:** [@wynro](https://github.com/wynro) **Created:** 8/25/2021 **Status:** ✅ Merged **Merged:** 8/25/2021 **Merged by:** [@ggongaware](https://github.com/ggongaware) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`1360747`](https://github.com/Telmate/proxmox-api-go/commit/1360747de5a79428b07bd350759424df65786411) Allow explicit empty parameters in request parameters ### 📊 Changes **3 files changed** (+104 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `proxmox/client.go` (+1 -1) 📝 `proxmox/session.go` (+13 -2) ➕ `proxmox/session_test.go` (+90 -0) </details> ### 📄 Description Sometimes, it may be useful to allow for empty parameters in the requests. The example that I'm finding is to allow removing the comment from a pool, but I'm sure it will be useful in other places. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>