[PR #120] [MERGED] Fixes #104 - Fix delete issue caused by []byte marshall #243

New issue

Closed

opened 2026-02-28 00:41:21 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 00:41:21 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Telmate/proxmox-api-go/pull/120
Author: @tagur87
Created: 5/7/2021
Status: ✅ Merged
Merged: 5/7/2021
Merged by: @ggongaware

Base: master ← Head: delete-node-issue

📝 Commits (1)

51bd4ae Fix delete issue caused by []byte marshall

📊 Changes

1 file changed (+8 additions, -1 deletions)

View changed files

📝 proxmox/client.go (+8 -1)

📄 Description

Based on suggested fix in #104

Delete's would not work properly because of the way the params were
passed through. If an empty list of params was passed, it would actually
Marshall that to a byte string like [34 34]

This is representative of '""' in the body of a curl http call. The
delete function requires no params so this may really be oboslete, but
this is a good workaround for now.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Telmate/proxmox-api-go/pull/120 **Author:** [@tagur87](https://github.com/tagur87) **Created:** 5/7/2021 **Status:** ✅ Merged **Merged:** 5/7/2021 **Merged by:** [@ggongaware](https://github.com/ggongaware) **Base:** `master` ← **Head:** `delete-node-issue` --- ### 📝 Commits (1) - [`51bd4ae`](https://github.com/Telmate/proxmox-api-go/commit/51bd4ae21d9a8ecdd7f040c48c240756616c7d08) Fix delete issue caused by []byte marshall ### 📊 Changes **1 file changed** (+8 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `proxmox/client.go` (+8 -1) </details> ### 📄 Description Based on suggested fix in #104 Delete's would not work properly because of the way the params were passed through. If an empty list of params was passed, it would actually Marshall that to a byte string like [34 34] This is representative of '""' in the body of a curl http call. The delete function requires no params so this may really be oboslete, but this is a good workaround for now. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>