[GH-ISSUE #125] Feature request: HA support for LXC containers #24

New issue

Closed

opened 2026-02-28 00:40:13 +03:00 by kerem · 1 comment

kerem commented

2026-02-28 00:40:13 +03:00

Owner

Originally created by @yesrod on GitHub (Jun 26, 2021).
Original GitHub issue: https://github.com/Telmate/proxmox-api-go/issues/125

First off, I apologize for the state of this issue, but my Go knowledge is limited. If anything I say is completely incorrect, please let me know.

Looking at the existing state of this API, it appears that the LXC container part doesn't handle HA configuration, but the QEMU VM part does. Specifically, the LXC container part is missing the hastate parameter.

If I'm reading the code correctly, the UpdateVMHA() function at https://github.com/Telmate/proxmox-api-go/blob/master/proxmox/client.go#L1172 should support setting up the HA resource for a LXC container already. If that is correct, then the LXC container part just needs a few things to also support HA, and config_qemu.go could be used as a reference to add that support.

Unfortunately, I don't understand the code well enough yet to make an attempt on my own to add this support. I would greatly appreciate if someone more familiar with the code could add this support.

Originally created by @yesrod on GitHub (Jun 26, 2021). Original GitHub issue: https://github.com/Telmate/proxmox-api-go/issues/125 First off, I apologize for the state of this issue, but my Go knowledge is limited. If anything I say is completely incorrect, please let me know. Looking at the existing state of this API, it appears that the LXC container part doesn't handle HA configuration, but the QEMU VM part does. Specifically, the LXC container part is missing the `hastate` parameter. If I'm reading the code correctly, the UpdateVMHA() function at https://github.com/Telmate/proxmox-api-go/blob/master/proxmox/client.go#L1172 should support setting up the HA resource for a LXC container already. If that is correct, then the LXC container part just needs a few things to also support HA, and config_qemu.go could be used as a reference to add that support. Unfortunately, I don't understand the code well enough yet to make an attempt on my own to add this support. I would greatly appreciate if someone more familiar with the code could add this support.

kerem closed this issue

2026-02-28 00:40:13 +03:00

kerem commented

2026-02-28 00:40:14 +03:00

Author

Owner

@yesrod commented on GitHub (Jul 8, 2021):

I've filed pull request #126 to resolve this issue.

I also have the necessary changes for https://github.com/Telmate/terraform-provider-proxmox but I need this PR merged first due to the way that the Terraform provider finds this module.

@yesrod commented on GitHub (Jul 8, 2021): I've filed pull request #126 to resolve this issue. I also have the necessary changes for https://github.com/Telmate/terraform-provider-proxmox but I need this PR merged first due to the way that the Terraform provider finds this module.

kerem referenced this issue

2026-02-28 00:40:55 +03:00

[PR #24] [MERGED] Add create VM template functionality #161