[PR #116] [MERGED] Added efi disk #239

New issue

Closed

opened 2026-02-28 00:41:20 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 00:41:20 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Telmate/proxmox-api-go/pull/116
Author: @KnKay
Created: 4/27/2021
Status: ✅ Merged
Merged: 7/28/2021
Merged by: @ggongaware

Base: master ← Head: master

📝 Commits (10+)

c848cb9 Added efi disk
0146c0b Update config_qemu.go
d65a74f Update go.mod
c0edf06 Rewind to correct module for MR
71b4e53 Adding efi working
1f4fa7c Taking out the creation
839b7b6 Added method to create params
9712902 Use unset
2a64a66 Corrected efidisk
f9a664b Last minor things

📊 Changes

1 file changed (+33 additions, -0 deletions)

View changed files

📝 proxmox/config_qemu.go (+33 -0)

📄 Description

Hi all,

at the moment we try to get packer build proxmox with UEFI.
As they use your api, it seems I need to add the efi disk here at well.

I wonder, if adding simply the need here is fine.

For what I understand the api a string will be just fine!

Cheers!

KnKay!

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Telmate/proxmox-api-go/pull/116 **Author:** [@KnKay](https://github.com/KnKay) **Created:** 4/27/2021 **Status:** ✅ Merged **Merged:** 7/28/2021 **Merged by:** [@ggongaware](https://github.com/ggongaware) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (10+) - [`c848cb9`](https://github.com/Telmate/proxmox-api-go/commit/c848cb915b9f8705558eb3b9ae6bb77bbeb4b5c7) Added efi disk - [`0146c0b`](https://github.com/Telmate/proxmox-api-go/commit/0146c0b8162f8b7219c75f591f1fec1f0a7a85c3) Update config_qemu.go - [`d65a74f`](https://github.com/Telmate/proxmox-api-go/commit/d65a74f557146e50e7078509de70c31d8951bb18) Update go.mod - [`c0edf06`](https://github.com/Telmate/proxmox-api-go/commit/c0edf065fa4e25b39d4e4d4e7b18cca4959a70db) Rewind to correct module for MR - [`71b4e53`](https://github.com/Telmate/proxmox-api-go/commit/71b4e53349764143c0c2795d8041bb209e8378e6) Adding efi working - [`1f4fa7c`](https://github.com/Telmate/proxmox-api-go/commit/1f4fa7c2015ee5374967de2f1a3dd0b394d49ffe) Taking out the creation - [`839b7b6`](https://github.com/Telmate/proxmox-api-go/commit/839b7b6eb202435f50a7eda8b922feca91eae953) Added method to create params - [`9712902`](https://github.com/Telmate/proxmox-api-go/commit/9712902b0bb487a8f0e180228546fb2af1682690) Use unset - [`2a64a66`](https://github.com/Telmate/proxmox-api-go/commit/2a64a66b23b9a8e12417da3cb31ef7d20a402b2a) Corrected efidisk - [`f9a664b`](https://github.com/Telmate/proxmox-api-go/commit/f9a664b5f8f6a453daa8330a48ef56e72a4189b8) Last minor things ### 📊 Changes **1 file changed** (+33 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `proxmox/config_qemu.go` (+33 -0) </details> ### 📄 Description Hi all, at the moment we try to get packer build proxmox with UEFI. As they use your api, it seems I need to add the efi disk here at well. I wonder, if adding simply the need here is fine. For what I understand the api a string will be just fine! Cheers! KnKay! --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>