[PR #110] [MERGED] fix crash when cloud-init disk have missing size #238

New issue

Closed

opened 2026-02-28 00:41:20 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 00:41:20 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Telmate/proxmox-api-go/pull/110
Author: @msbence
Created: 3/30/2021
Status: ✅ Merged
Merged: 3/30/2021
Merged by: @ggongaware

Base: master ← Head: master

📝 Commits (1)

086e5b1 fix cloud-init disk with missing size

📊 Changes

1 file changed (+5 additions, -0 deletions)

View changed files

📝 proxmox/config_qemu.go (+5 -0)

📄 Description

There were some changes Proxmox side which resulted a missing size parameter in the API, and caused the application (and the provider using it) to crash.

My changes: the application now checks if the disk size is nil or not, and when it is then it sets the default cloud-init disk size if the disk is indeed a cloud-init one (by checking the filename).

PVE 6.3-6, cloud-init disk as scsi2

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Telmate/proxmox-api-go/pull/110 **Author:** [@msbence](https://github.com/msbence) **Created:** 3/30/2021 **Status:** ✅ Merged **Merged:** 3/30/2021 **Merged by:** [@ggongaware](https://github.com/ggongaware) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`086e5b1`](https://github.com/Telmate/proxmox-api-go/commit/086e5b1a916be37ff16d19a8d9427384517ca23c) fix cloud-init disk with missing size ### 📊 Changes **1 file changed** (+5 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `proxmox/config_qemu.go` (+5 -0) </details> ### 📄 Description There were some changes Proxmox side which resulted a missing `size` parameter in the API, and caused the application (and the provider using it) to crash. My changes: the application now checks if the disk size is `nil` or not, and when it is then it sets the default cloud-init disk size if the disk is indeed a cloud-init one (by checking the filename). PVE 6.3-6, cloud-init disk as `scsi2` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>