mirror of
https://github.com/Telmate/proxmox-api-go.git
synced 2026-04-25 23:45:55 +03:00
[PR #99] [MERGED] Add unused disk attribute for Qemu VMs #230
Labels
No labels
good first issue
issue/confirmed
issue/critical
proposal/accepted
pull-request
type/bug
type/enhancement
type/feature
type/question
type/refactoring
type/testing
type/testing
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/proxmox-api-go#230
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/Telmate/proxmox-api-go/pull/99
Author: @doransmestad
Created: 11/14/2020
Status: ✅ Merged
Merged: 11/17/2020
Merged by: @ggongaware
Base:
master← Head:dsmestad-add-unused-disks📝 Commits (1)
b2ac729Add unused disk attributes for qemu vms📊 Changes
1 file changed (+94 additions, -58 deletions)
View changed files
📝
proxmox/config_qemu.go(+94 -58)📄 Description
This pull request adds an "unused_disk" attribute to Qemu VMs so users of this library are able to see unused disks in proxmox (when a disk is "detached" from a virtual machine, but not removed). This PR is intended to only add read functionality for unused_disks, but does not add the ability to actually perform a disk detachment. I figure we can add that in later if/when needed.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.