[PR #98] [MERGED] fix disk recreating when Proxmox converts disk size from 1024G to 1T #228

New issue

Closed

opened 2026-02-28 00:41:17 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 00:41:17 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Telmate/proxmox-api-go/pull/98
Author: @yukron
Created: 11/12/2020
Status: ✅ Merged
Merged: 11/19/2020
Merged by: @ggongaware

Base: master ← Head: master

📝 Commits (2)

5c09cc5 fix unwanted disk recreating when Proxmox converts disk size from 1024G to 1T
a342501 fixed storage_type & format for disk (#100)

📊 Changes

2 files changed (+21 additions, -5 deletions)

View changed files

📝 proxmox/config_qemu.go (+17 -3)
📝 proxmox/util.go (+4 -2)

📄 Description

When creating disk with 1024G size, Proxmox saves it as 1T and trying to apply the same resource leads to disk size update. See this issues: https://github.com/Telmate/terraform-provider-proxmox/issues/247

This PR should fix it, though was not tested properly.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Telmate/proxmox-api-go/pull/98 **Author:** [@yukron](https://github.com/yukron) **Created:** 11/12/2020 **Status:** ✅ Merged **Merged:** 11/19/2020 **Merged by:** [@ggongaware](https://github.com/ggongaware) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (2) - [`5c09cc5`](https://github.com/Telmate/proxmox-api-go/commit/5c09cc5d488989fc13fde07f4a4c0d932157e20d) fix unwanted disk recreating when Proxmox converts disk size from 1024G to 1T - [`a342501`](https://github.com/Telmate/proxmox-api-go/commit/a3425019af82d0743868d31e7cdf06e16576c8e2) fixed storage_type & format for disk (#100) ### 📊 Changes **2 files changed** (+21 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `proxmox/config_qemu.go` (+17 -3) 📝 `proxmox/util.go` (+4 -2) </details> ### 📄 Description When creating disk with 1024G size, Proxmox saves it as 1T and trying to apply the same resource leads to disk size update. See this issues: https://github.com/Telmate/terraform-provider-proxmox/issues/247 This PR should fix it, though was not tested properly. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>