mirror of
https://github.com/Telmate/proxmox-api-go.git
synced 2026-04-25 23:45:55 +03:00
[PR #97] [MERGED] converting nic's firewall integers to bool #226
Labels
No labels
good first issue
issue/confirmed
issue/critical
proposal/accepted
pull-request
type/bug
type/enhancement
type/feature
type/question
type/refactoring
type/testing
type/testing
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/proxmox-api-go#226
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/Telmate/proxmox-api-go/pull/97
Author: @yukron
Created: 11/9/2020
Status: ✅ Merged
Merged: 11/9/2020
Merged by: @ggongaware
Base:
master← Head:master📝 Commits (1)
8faba04converting nic's firewall integers to bool📊 Changes
1 file changed (+5 additions, -0 deletions)
View changed files
📝
proxmox/config_qemu.go(+5 -0)📄 Description
This solves errors like
Error: network.0.firewall: '' expected type 'bool', got unconvertible type 'int'when importing existing configuration (since Proxmox responds with integers for this configuration and terraform expects Boolean, see scheme).🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.